[PR #20271] [MERGED] fix: prevent get_user_ids_from_room crash on missing session #129191

New Issue

GiteaMirror · 2026-05-21T12:19:11-05:00

GiteaMirror commented

2026-05-21 12:19:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20271
Author: @Classic298
Created: 12/30/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @tjbck

Base: dev ← Head: fix/issue-003-get-user-ids-session-crash

📝 Commits (1)

6228a67 fix: prevent get_user_ids_from_room crash on missing session

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 backend/open_webui/socket/main.py (+5 -1)

📄 Description

Add null check in list comprehension before accessing session['id']. When a session_id exists in the room but has been removed from SESSION_POOL, the function now skips it instead of crashing with TypeError.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20271 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/30/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/issue-003-get-user-ids-session-crash` --- ### 📝 Commits (1) - [`6228a67`](https://github.com/open-webui/open-webui/commit/6228a67cfd0feafa4af55761e957a099ec3b3976) fix: prevent get_user_ids_from_room crash on missing session ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/socket/main.py` (+5 -1) </details> ### 📄 Description Add null check in list comprehension before accessing session['id']. When a session_id exists in the room but has been removed from SESSION_POOL, the function now skips it instead of crashing with TypeError. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 12:19:11 -05:00

GiteaMirror closed this issue

2026-05-21 12:19:14 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#129191