github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-17 08:21:12 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #19670] [MERGED] fix: Correct web search filter logic to consistently block filtered domains #128960

New Issue
Closed
opened 2026-05-21 12:01:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 12:01:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19670
Author: @kjpoccia
Created: 12/1/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @tjbck

Base: dev ← Head: web-search-block

📝 Commits (2)

  • 5a62faf fix/adjust web search to properly block domains
  • c0b3bec Merge branch 'dev' into web-search-block

📊 Changes

2 files changed (+11 additions, -7 deletions)

View changed files

📝 backend/open_webui/retrieval/web/main.py (+1 -1)
📝 backend/open_webui/utils/misc.py (+10 -6)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

🔒 Web search filtering now correctly blocks results when any resolved hostname or IP address matches a blocked domain, preventing blocked sites from appearing due to permissive hostname resolution.

Description

Related issue: #19669

This PR fixes an issue in the web search filtering logic where blocked domains (prefixed with !) were still allowed if any resolved hostname or IP address passed the filter check.

Web search filtering currently behaves incorrectly when a domain resolves to multiple hostnames or IP addresses.
In get_filtered_results, each search result domain is resolved to:

  • the original domain (e.g. www.accuweather.com)
  • plus one or more IPv4 / IPv6 addresses
    Each value is then passed individually to is_string_allowed; if any one of those values is allowed, the entire search result is included.

This behavior contradicts the expected semantics of a block rule: if any resolved hostname or IP is blocked, the entire result should be excluded.

2025-12-01 15 46 43

The issue is caused by this logic:

if any(is_string_allowed(hostname, filter_list) for hostname in hostnames):
    filtered_results.append(result)

Changed

  • is_string_allowed now evaluates a sequence of resolved hostnames/IPs together to ensure block rules are applied consistently to an entire search result.

Additional Information

The logs show the issue clearly with the resolved hostnames logged in get_filtered_results. The hostnames are all associated with a single result, and because the resolved IP addresses are not explicitly blocked, the YouTube result is incorrectly allowed through.

DEBUG: hostnames in get_filtered_results: ['www.youtube.com', '172.217.4.46', '172.217.4.46', '172.217.4.46', '142.250.191.206', '142.250.191.206', '142.250.191.206', <ip list truncated for brevity>]

DEBUG: is_string_allowed string: [www.youtube.com,⁠](http://www.youtube.com,/) allow_list: [], block_list: ['www.accuweather.com', 'www.youtube.com']

DEBUG: is_string_allowed string: 172.217.4.46, allow_list: [], block_list: ['www.accuweather.com', 'www.youtube.com']

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19670 **Author:** [@kjpoccia](https://github.com/kjpoccia) **Created:** 12/1/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `web-search-block` --- ### 📝 Commits (2) - [`5a62faf`](https://github.com/open-webui/open-webui/commit/5a62faf81b625f026490496631f6ca0a5f3c17a8) fix/adjust web search to properly block domains - [`c0b3bec`](https://github.com/open-webui/open-webui/commit/c0b3beca219b58dafb5b738ce7f9b9d0824068ab) Merge branch 'dev' into web-search-block ### 📊 Changes **2 files changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/main.py` (+1 -1) 📝 `backend/open_webui/utils/misc.py` (+10 -6) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry 🔒 Web search filtering now correctly blocks results when any resolved hostname or IP address matches a blocked domain, preventing blocked sites from appearing due to permissive hostname resolution. ### Description Related issue: #19669 This PR fixes an issue in the web search filtering logic where blocked domains (prefixed with !) were still allowed if any resolved hostname or IP address passed the filter check. Web search filtering currently behaves incorrectly when a domain resolves to multiple hostnames or IP addresses. In `get_filtered_results`, each search result domain is resolved to: * the original domain (e.g. www.accuweather.com) * plus one or more IPv4 / IPv6 addresses Each value is then passed individually to `is_string_allowed`; if any one of those values is allowed, the entire search result is included. This behavior contradicts the expected semantics of a block rule: if any resolved hostname or IP is blocked, the entire result should be excluded. ![2025-12-01 15 46 43](https://github.com/user-attachments/assets/c23a366b-ad64-445a-9a67-7f671fcb1150) The issue is caused by this logic: ```python if any(is_string_allowed(hostname, filter_list) for hostname in hostnames): filtered_results.append(result) ``` ### Changed - `is_string_allowed` now evaluates a sequence of resolved hostnames/IPs together to ensure block rules are applied consistently to an entire search result. --- ### Additional Information The logs show the issue clearly with the resolved hostnames logged in `get_filtered_results`. The hostnames are all associated with a single result, and because the resolved IP addresses are not explicitly blocked, the YouTube result is incorrectly allowed through. ```bash DEBUG: hostnames in get_filtered_results: ['www.youtube.com', '172.217.4.46', '172.217.4.46', '172.217.4.46', '142.250.191.206', '142.250.191.206', '142.250.191.206', <ip list truncated for brevity>] DEBUG: is_string_allowed string: [www.youtube.com,⁠](http://www.youtube.com,/) allow_list: [], block_list: ['www.accuweather.com', 'www.youtube.com'] DEBUG: is_string_allowed string: 172.217.4.46, allow_list: [], block_list: ['www.accuweather.com', 'www.youtube.com'] ``` ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 12:01:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#128960
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?