[PR #19053] [CLOSED] feat: allow custom models to inherit base model settings #128732

New Issue

GiteaMirror · 2026-05-21T11:27:54-05:00

GiteaMirror commented

2026-05-21 11:27:54 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19053
Author: @kjpoccia
Created: 11/8/2025
Status: ❌ Closed

Base: dev ← Head: feat/inherit-base-model-settings

📝 Commits (2)

e0d5de1 Merge pull request #18978 from open-webui/dev
60befa0 feat: allow custom models to inherit advanced params and default features from base model

📊 Changes

1 file changed (+116 additions, -3 deletions)

View changed files

📝 src/lib/components/workspace/Models/ModelEditor.svelte (+116 -3)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

Relevant discussion #18994

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

✨ The model editor now supports inheriting configuration from a selected base model via an “Inherit settings” toggle and a “Fetch latest settings” control, making custom models consistent-by-default by inheriting vetted defaults from the selected base model, reducing configuration drift and user error.

Description

This PR allows custom models to inherit configuration from the selected base model. Introduces an “Inherit settings from base model” toggle and a “Fetch latest settings” control in the custom model editor.

Benefits:

Don't need to rely on users to be knowledgeable about advanced params
Prevents accidental configuration drift when users create custom models (e.g., native tool-calling, context length, top-k).
Helps admins enforce org defaults and reduce support churn.
Makes the “base model” concept more intuitive and powerful by treating it as a source of truth.

Inherit behavior:

When "inherit" toggle is on (default), copies advanced params and defaultFeatureIds from a saved overlay (via getModelById) when available, with the exception of system prompt.
Copies defaultFeatureIds from overlay or falls back to the frontend model list metadata when no overlay is present.
If toggle is off, updating the base model has no effect on advanced params or defaultFeatureIds, so users can opt out
"Fetch latest settings" allows users to fetch any updated settings in the base model since the custom model's creation

Added

Base Model selector has “Inherit settings” toggle (defaults to on) and “Fetch latest settings.”
Toggleable inheritance of advanced params (excluding system prompt) and defaultFeatureIds from overlay or fallback metadata.

Breaking Changes

BREAKING CHANGE: None. The "inherit settings" toggle is automatically on when a custom model is created, but existing custom models won't be affected by this change unless the user clicks "Fetch latest settings," or selects a new model without turning the inherit settings toggle off.

Screenshots or Videos

In the below gif, we configure a base model how we want it:
Then we create a custom model based on that base model. We can see the advanced params are inherited:
We then decide to update the base model configuration. We can see the custom model is unaffected. The user may wish to fetch any new settings at some point in the future, so they can click "Fetch latest settings":
If the user then wants to update the base model, but doesn't want to update the configured params, they can toggle off the "Inherit settings" toggle and their params won't be affected when they update models.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19053 **Author:** [@kjpoccia](https://github.com/kjpoccia) **Created:** 11/8/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/inherit-base-model-settings` --- ### 📝 Commits (2) - [`e0d5de1`](https://github.com/open-webui/open-webui/commit/e0d5de16978786b8a7538adf1efcde5258f38faf) Merge pull request #18978 from open-webui/dev - [`60befa0`](https://github.com/open-webui/open-webui/commit/60befa01cf70ac5220004e2a46c28a70c13bf14d) feat: allow custom models to inherit advanced params and default features from base model ### 📊 Changes **1 file changed** (+116 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+116 -3) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. Relevant discussion #18994 This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ✨ The model editor now supports inheriting configuration from a selected base model via an “Inherit settings” toggle and a “Fetch latest settings” control, making custom models consistent-by-default by inheriting vetted defaults from the selected base model, reducing configuration drift and user error. ### Description This PR allows custom models to inherit configuration from the selected base model. Introduces an “Inherit settings from base model” toggle and a “Fetch latest settings” control in the custom model editor. Benefits: * Don't need to rely on users to be knowledgeable about advanced params * Prevents accidental configuration drift when users create custom models (e.g., native tool-calling, context length, top-k). * Helps admins enforce org defaults and reduce support churn. * Makes the “base model” concept more intuitive and powerful by treating it as a source of truth. Inherit behavior: * When "inherit" toggle is on (default), copies advanced params and defaultFeatureIds from a saved overlay (via getModelById) when available, with the exception of system prompt. * Copies defaultFeatureIds from overlay or falls back to the frontend model list metadata when no overlay is present. * If toggle is off, updating the base model has no effect on advanced params or defaultFeatureIds, so users can opt out * "Fetch latest settings" allows users to fetch any updated settings in the base model since the custom model's creation ### Added - Base Model selector has “Inherit settings” toggle (defaults to on) and “Fetch latest settings.” - Toggleable inheritance of advanced params (excluding system prompt) and defaultFeatureIds from overlay or fallback metadata. ### Breaking Changes - **BREAKING CHANGE**: None. The "inherit settings" toggle is automatically on when a custom model is created, but existing custom models won't be affected by this change unless the user clicks "Fetch latest settings," or selects a new model without turning the inherit settings toggle off. --- ### Screenshots or Videos - In the below gif, we configure a base model how we want it: ![outputpart1](https://github.com/user-attachments/assets/d5c81966-2c60-4c91-b072-90b0291550be) - Then we create a custom model based on that base model. We can see the advanced params are inherited: ![outputpart2](https://github.com/user-attachments/assets/3188ca7e-5f66-45a9-b6dc-074ad43eb72d) - We then decide to update the base model configuration. We can see the custom model is unaffected. The user may wish to fetch any new settings at some point in the future, so they can click "Fetch latest settings": ![outputpart3](https://github.com/user-attachments/assets/bfd204dc-9728-412c-8e8b-2beff1e2da2e) - If the user then wants to update the base model, but doesn't want to update the configured params, they can toggle off the "Inherit settings" toggle and their params won't be affected when they update models. ![outputpart4](https://github.com/user-attachments/assets/2a805755-f7a0-4d3a-817f-8046178b67ae) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 11:27:55 -05:00

GiteaMirror closed this issue

2026-05-21 11:28:03 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#128732