[PR #18682] [CLOSED] feat: add approximate total for chat completions #128537

New Issue

GiteaMirror · 2026-05-21T11:04:52-05:00

GiteaMirror commented

2026-05-21 11:04:52 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18682
Author: @ryan-steed-usa
Created: 10/28/2025
Status: ❌ Closed

Base: dev ← Head: extend-cleanup-approximate-total

📝 Commits (1)

6df0d2c feat: add approximate total for chat completions

📊 Changes

4 files changed (+31 additions, -24 deletions)

View changed files

📝 backend/open_webui/utils/chat.py (+2 -1)
📝 backend/open_webui/utils/response.py (+29 -0)
📝 src/lib/components/chat/Messages/ResponseMessage.svelte (+0 -1)
📝 src/lib/utils/index.ts (+0 -22)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This commit introduces a new feature to calculate and inject approximate total time estimates for chat completions.

Added

Added calculate_chat_completion_approximate_total function in backend/open_webui/utils/response.py that processes OpenAI-compatible data to compute approximate total time from prompt and predicted milliseconds

Changed

Updated chat_completed function in backend/open_webui/utils/chat.py to use the new calculation function before processing filters

Removed

Removed unused approximateToHumanReadable utility function from src/lib/utils/index.ts as it's now superseded by the backend calculation
Removed import of approximateToHumanReadable from src/lib/components/chat/Messages/ResponseMessage.svelte since it's no longer needed

Additional Information

The approximate total is calculated as: (prompt_ms + predicted_ms) / 1000 seconds, formatted as "XhYmZs" where X, Y, Z are hours, minutes, and seconds respectively. This provides users with a human-readable estimate of the processing time for each message in the chat completion response.

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18682 **Author:** [@ryan-steed-usa](https://github.com/ryan-steed-usa) **Created:** 10/28/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `extend-cleanup-approximate-total` --- ### 📝 Commits (1) - [`6df0d2c`](https://github.com/open-webui/open-webui/commit/6df0d2cd2340bb024d3cfbe3560172d94c23defa) feat: add approximate total for chat completions ### 📊 Changes **4 files changed** (+31 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/chat.py` (+2 -1) 📝 `backend/open_webui/utils/response.py` (+29 -0) 📝 `src/lib/components/chat/Messages/ResponseMessage.svelte` (+0 -1) 📝 `src/lib/utils/index.ts` (+0 -22) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [X] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This commit introduces a new feature to calculate and inject approximate total time estimates for chat completions. ### Added - Added `calculate_chat_completion_approximate_total` function in `backend/open_webui/utils/response.py` that processes OpenAI-compatible data to compute approximate total time from prompt and predicted milliseconds ### Changed - Updated `chat_completed` function in `backend/open_webui/utils/chat.py` to use the new calculation function before processing filters ### Removed - Removed unused `approximateToHumanReadable` utility function from `src/lib/utils/index.ts` as it's now superseded by the backend calculation - Removed import of `approximateToHumanReadable` from `src/lib/components/chat/Messages/ResponseMessage.svelte` since it's no longer needed --- ### Additional Information - The approximate total is calculated as: (prompt_ms + predicted_ms) / 1000 seconds, formatted as "XhYmZs" where X, Y, Z are hours, minutes, and seconds respectively. This provides users with a human-readable estimate of the processing time for each message in the chat completion response. ### Screenshots or Videos <img width="341" height="104" alt="image" src="https://github.com/user-attachments/assets/be73cc1c-c567-420e-875b-bcb43fef3048" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 11:04:52 -05:00

GiteaMirror closed this issue

2026-05-21 11:04:55 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#128537