github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-08-30 17:25:30 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

enh: Replace Peewee with SQLAlchemy due to multithreading issues #1282

New Issue
Closed
opened 2025-11-11 14:41:47 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-11 14:41:47 -06:00
Owner
Copy Link
Copy Source

Originally created by @jonathan-rohde on GitHub (Jun 17, 2024).

Is your feature request related to a problem? Please describe.
When using the application, the database connection gets still sooner or later. The root cause relies here in the multithreaded environment of FastAPI

Describe the solution you'd like
Replace Peewee ORM with SQLAlchemy

Describe alternatives you've considered
There exists a possibility to do an auto-reconnect for certain db related errors. But in my opinion this just hides the real issue. In some cases it might solve the users need, but it is not very reliable.
Additional there is a peewee-async project that can handle it. But reworking the backend to fit the async dependency is just at least the same effort as replacing it with SQLAlchemy. Considering if a library will be maintained in the future, I would rather bet with SQLAlchemy than peewee-async

Additional context
Screenshot 2024-06-17 at 10 42 21
https://github.com/tiangolo/fastapi/issues/1019#issuecomment-612921599

Originally created by @jonathan-rohde on GitHub (Jun 17, 2024). **Is your feature request related to a problem? Please describe.** When using the application, the database connection gets still sooner or later. The root cause relies here in the multithreaded environment of FastAPI **Describe the solution you'd like** Replace Peewee ORM with SQLAlchemy **Describe alternatives you've considered** There exists a possibility to do an auto-reconnect for certain db related errors. But in my opinion this just hides the real issue. In some cases it might solve the users need, but it is not very reliable. Additional there is a peewee-async project that can handle it. But reworking the backend to fit the async dependency is just at least the same effort as replacing it with SQLAlchemy. Considering if a library will be maintained in the future, I would rather bet with SQLAlchemy than peewee-async **Additional context** ![Screenshot 2024-06-17 at 10 42 21](https://github.com/open-webui/open-webui/assets/165899591/2665305e-c0fd-4b54-bd92-2c0841343bac) https://github.com/tiangolo/fastapi/issues/1019#issuecomment-612921599
GiteaMirror added the enhancementgood first issuehelp wantedcore labels 2025-11-11 14:41:47 -06:00
GiteaMirror commented 2025-11-11 14:41:48 -06:00
Author
Owner
Copy Link
Copy Source

@tjbck commented on GitHub (Jun 17, 2024):

PR welcome!

@tjbck commented on GitHub (Jun 17, 2024): PR welcome!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No labels core enhancement good first issue help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#1282