[PR #17158] [MERGED] perf: fix cache key generation for model list caching #127994

New Issue

GiteaMirror · 2026-05-21T10:20:02-05:00

GiteaMirror commented

2026-05-21 10:20:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17158
Author: @sihyeonn
Created: 9/2/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @tjbck

Base: dev ← Head: fix/sh-cache

📝 Commits (1)

3ccbb46 perf: fix cache key generation for model list caching

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/ollama.py (+1 -1)
📝 backend/open_webui/routers/openai.py (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed cache key generation for model list endpoints to use user.id instead of Request objects, enabling proper caching functionality and reducing redundant API calls to external model providers

Changed

Modified cache key generation in get_all_models functions for both Ollama and OpenAI routers
Cache keys now use f"{provider}_all_models_{user.id}" format instead of Request-based keys
Improved cache hit rates for repeated model list requests from the same user

Fixed

Fixed broken caching mechanism where Request objects prevented cache hits
Reduced unnecessary API calls to external model providers (Ollama, OpenAI, etc.)
Improved response times for model list requests through effective caching

Additional Information

Files affected:
- backend/open_webui/routers/ollama.py (line 343)
- backend/open_webui/routers/openai.py (line 404)
Cache key format: {provider}_all_models_{user_id} for authenticated users, {provider}_all_models for anonymous users
TTL: Uses existing MODELS_CACHE_TTL configuration
User isolation: Each user maintains separate cache entries, preventing data leakage

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17158 **Author:** [@sihyeonn](https://github.com/sihyeonn) **Created:** 9/2/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/sh-cache` --- ### 📝 Commits (1) - [`3ccbb46`](https://github.com/open-webui/open-webui/commit/3ccbb4693809f12380daa5c1e7e180f9afe45310) perf: fix cache key generation for model list caching ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/ollama.py` (+1 -1) 📝 `backend/open_webui/routers/openai.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed cache key generation for model list endpoints to use user.id instead of Request objects, enabling proper caching functionality and reducing redundant API calls to external model providers ### Changed - Modified cache key generation in `get_all_models` functions for both Ollama and OpenAI routers - Cache keys now use `f"{provider}_all_models_{user.id}"` format instead of Request-based keys - Improved cache hit rates for repeated model list requests from the same user ### Fixed - Fixed broken caching mechanism where Request objects prevented cache hits - Reduced unnecessary API calls to external model providers (Ollama, OpenAI, etc.) - Improved response times for model list requests through effective caching --- ### Additional Information - **Files affected:** - `backend/open_webui/routers/ollama.py` (line 343) - `backend/open_webui/routers/openai.py` (line 404) - **Cache key format:** `{provider}_all_models_{user_id}` for authenticated users, `{provider}_all_models` for anonymous users - **TTL:** Uses existing `MODELS_CACHE_TTL` configuration - **User isolation:** Each user maintains separate cache entries, preventing data leakage ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 10:20:02 -05:00

GiteaMirror closed this issue

2026-05-21 10:20:04 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#127994