[PR #16417] [MERGED] fix: Prevent idle transactions with PGvector DB #127779

Closed
opened 2026-05-21 09:56:51 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16417
Author: @Ithanil
Created: 8/9/2025
Status: Merged
Merged: 8/9/2025
Merged by: @tjbck

Base: devHead: prevent_idle_transactions


📝 Commits (1)

  • 3a9601c use .rollback() after read-only transaction on pgvector to avoid infinitely idle transactions (and errors in certain scenarios)

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/dbs/pgvector.py (+8 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The current implementation of PgvectorClient doesn't call commit() at the end of read-only methods (which of course seems intuitively correct), leaving idle in transaction transactions. The pg_stat-activity would look like so:

openwebui=# SELECT 
    pid, 
    usename, 
    application_name, 
    client_addr, 
    query_start, 
    state 
FROM 
    pg_stat_activity 
WHERE  
    query NOT LIKE '%pg_stat_activity%'
ORDER BY 
    query_start ASC;
  pid   |  usename   | application_name | client_addr |          query_start          |        state        
--------+------------+------------------+-------------+-------------------------------+---------------------
....
 329961 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:31:07.244193+02 | idle
 329954 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:32:59.133255+02 | idle in transaction
 329960 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:33:44.001915+02 | idle
 329551 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.736138+02 | idle
 329510 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.742168+02 | idle
 329405 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.904287+02 | idle
 329401 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.910246+02 | idle
 329503 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.942612+02 | idle
 329482 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.9471+02   | idle
 329523 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:38.951378+02 | idle
 329546 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:39.002317+02 | idle
 329572 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:39.008305+02 | idle
 329702 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:39.292772+02 | idle
 332930 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:39.378427+02 | idle in transaction
 332935 | openwebui  |                  | 1.2.3.4 | 2025-08-09 19:34:57.216976+02 | idle in transaction
....

Now, setting the parameter idle_in_transaction_session_timeout on the database, which would be best practice, would close these session, producing error messages at the minimum.

More concerning though, in certain scenarios you would find the following error:

ERROR | open_webui.retrieval.vector.dbs.pgvector:search:423 - Error during search: Can't reconnect until invalid transaction is rolled back. Please rollback() fully before proceeding (Background on this error at: https://sqlalche.me/e/20/8s2b) - {}

The present PR fixes both of these issues by explicitly "rolling back" the read-only transactions to close them, which appears to be the safest choice (without changing the whole implementation). Since the methods are meant to be read-only, there should be nothing to rollback. Of course there should be nothing to commit as well, but rolling back still appears the most robust choice.

Tested and indeed prevents any idle in transaction without any issue.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16417 **Author:** [@Ithanil](https://github.com/Ithanil) **Created:** 8/9/2025 **Status:** ✅ Merged **Merged:** 8/9/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `prevent_idle_transactions` --- ### 📝 Commits (1) - [`3a9601c`](https://github.com/open-webui/open-webui/commit/3a9601c053a7edfceb2e47d7ebc73a2ad2f7a88f) use .rollback() after read-only transaction on pgvector to avoid infinitely idle transactions (and errors in certain scenarios) ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/dbs/pgvector.py` (+8 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description The current implementation of PgvectorClient doesn't call commit() at the end of read-only methods (which of course seems intuitively correct), leaving `idle in transaction` transactions. The pg_stat-activity would look like so: ``` openwebui=# SELECT pid, usename, application_name, client_addr, query_start, state FROM pg_stat_activity WHERE query NOT LIKE '%pg_stat_activity%' ORDER BY query_start ASC; pid | usename | application_name | client_addr | query_start | state --------+------------+------------------+-------------+-------------------------------+--------------------- .... 329961 | openwebui | | 1.2.3.4 | 2025-08-09 19:31:07.244193+02 | idle 329954 | openwebui | | 1.2.3.4 | 2025-08-09 19:32:59.133255+02 | idle in transaction 329960 | openwebui | | 1.2.3.4 | 2025-08-09 19:33:44.001915+02 | idle 329551 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.736138+02 | idle 329510 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.742168+02 | idle 329405 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.904287+02 | idle 329401 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.910246+02 | idle 329503 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.942612+02 | idle 329482 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.9471+02 | idle 329523 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:38.951378+02 | idle 329546 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:39.002317+02 | idle 329572 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:39.008305+02 | idle 329702 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:39.292772+02 | idle 332930 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:39.378427+02 | idle in transaction 332935 | openwebui | | 1.2.3.4 | 2025-08-09 19:34:57.216976+02 | idle in transaction .... ``` Now, setting the parameter `idle_in_transaction_session_timeout` on the database, which would be best practice, would close these session, producing error messages at the minimum. More concerning though, in certain scenarios you would find the following error: `ERROR | open_webui.retrieval.vector.dbs.pgvector:search:423 - Error during search: Can't reconnect until invalid transaction is rolled back. Please rollback() fully before proceeding (Background on this error at: https://sqlalche.me/e/20/8s2b) - {}` The present PR fixes both of these issues by explicitly "rolling back" the read-only transactions to close them, which appears to be the safest choice (without changing the whole implementation). Since the methods are meant to be read-only, there should be nothing to `rollback`. Of course there should be nothing to `commit` as well, but rolling back still appears the most robust choice. Tested and indeed prevents any idle in transaction without any issue. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 09:56:51 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#127779