[PR #11423] [MERGED] feat: add more confirmation prompts #126387

New Issue

GiteaMirror · 2026-05-21T07:35:00-05:00

GiteaMirror commented

2026-05-21 07:35:00 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11423
Author: @silentoplayz
Created: 3/8/2025
Status: ✅ Merged
Merged: 3/9/2025
Merged by: @tjbck

Base: dev ← Head: confirmation-prompts

📝 Commits (1)

d669932 add confirmation prompts

📊 Changes

5 files changed (+64 additions, -6 deletions)

View changed files

📝 src/lib/components/admin/Settings/Connections/OllamaConnection.svelte (+13 -1)
📝 src/lib/components/admin/Settings/Connections/OpenAIConnection.svelte (+12 -1)
📝 src/lib/components/admin/Settings/Evaluations/ArenaModelModal.svelte (+11 -2)
📝 src/lib/components/admin/Users/UserList/UserChatsModal.svelte (+15 -1)
📝 src/lib/components/chat/Settings/Connections/Connection.svelte (+13 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

These updates in the PR includes the addition of a confirmation dialog for deletions and expanded deletion logic. This PR leaves room for improvements to be made to each of the confirmation dialogs added, as they're standardized and not specifically tailored to each one.

Related - https://github.com/open-webui/open-webui/pull/10786

Added/Changed

The main additions include the import of ConfirmDialog and Tooltip components, as well as updates to the modal and confirmation dialog setup.

The following new confirmation dialog prompts were added in this PR:

Confirmation prompt for deleting a direct connection.
Confirmation prompt for deleting admin OpenAI API connections.
Confirmation prompt for deleting admin Ollama API Connections.
Confirmation prompt for deleting an arena model.
Confirmation prompt for deleting a user's chat as an admin from the admin panel.

Fixed

Not a fix per say, but I felt these confirmation prompts are necessary to have in crucial areas of the UI where things can accidentally be deleted.

Screenshots or Videos

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11423 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 3/8/2025 **Status:** ✅ Merged **Merged:** 3/9/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `confirmation-prompts` --- ### 📝 Commits (1) - [`d669932`](https://github.com/open-webui/open-webui/commit/d669932137c89f240271966884ee1d61597023e7) add confirmation prompts ### 📊 Changes **5 files changed** (+64 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings/Connections/OllamaConnection.svelte` (+13 -1) 📝 `src/lib/components/admin/Settings/Connections/OpenAIConnection.svelte` (+12 -1) 📝 `src/lib/components/admin/Settings/Evaluations/ArenaModelModal.svelte` (+11 -2) 📝 `src/lib/components/admin/Users/UserList/UserChatsModal.svelte` (+15 -1) 📝 `src/lib/components/chat/Settings/Connections/Connection.svelte` (+13 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - **These updates in the PR includes the addition of a confirmation dialog for deletions and expanded deletion logic. This PR leaves room for improvements to be made to each of the confirmation dialogs added, as they're standardized and not specifically tailored to each one.** Related - https://github.com/open-webui/open-webui/pull/10786 ### Added/Changed - **The main additions include the import of `ConfirmDialog` and `Tooltip` components, as well as updates to the modal and confirmation dialog setup.** **The following new confirmation dialog prompts were added in this PR:** - Confirmation prompt for deleting a direct connection. - Confirmation prompt for deleting admin OpenAI API connections. - Confirmation prompt for deleting admin Ollama API Connections. - Confirmation prompt for deleting an arena model. - Confirmation prompt for deleting a user's chat as an admin from the admin panel. ### Fixed - Not a fix per say, but I felt these confirmation prompts are necessary to have in crucial areas of the UI where things can accidentally be deleted. --- ### Screenshots or Videos ![image](https://github.com/user-attachments/assets/945e1dad-ecc1-45a3-8938-d3a20ef349fe) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 07:35:00 -05:00

GiteaMirror closed this issue

2026-05-21 07:35:04 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#126387