Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
I have been experiencing the issue "Oops! The URL you provided is invalid. Please double-check and try again."
It is a result of Searxng returning invalid urls as part of the search results. For example, I saw a URL that had a malformed query string (no =value after the ?query)
This PR only allows valid URLs to be used during a web search
Added
None
Changed
None
Deprecated
None
Removed
None
Fixed
Prevent invalid URLs from being loaded by the RAG web loader
Security
None
Breaking Changes
None
Additional Information
This code was separated from https://github.com/open-webui/open-webui/pull/9263 - I've tested them individually, but they are intended to go together. There are going to be merge conflicts when merging them together - please use "safe_urls" as the inputs to the web loader when resolving these conflicts.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/9314
**Author:** [@roryeckel](https://github.com/roryeckel)
**Created:** 2/4/2025
**Status:** ✅ Merged
**Merged:** 2/4/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `validate-rag-urls`
---
### 📝 Commits (4)
- [`121a13d`](https://github.com/open-webui/open-webui/commit/121a13d4ed62a77ea6c1bc9c0b5628644c264112) fix: Filter to valid RAG web search URLs
- [`3db6b43`](https://github.com/open-webui/open-webui/commit/3db6b4352fdb75d469fc58e272d2de2e0b071b5c) fix: Filter out invalid RAG web URLs (continued)
- [`310a18e`](https://github.com/open-webui/open-webui/commit/310a18eef2d2bb80c0ab92aca959675ebf470595) Merge branch 'dev' into validate-rag-urls
- [`1a1cc15`](https://github.com/open-webui/open-webui/commit/1a1cc1514f339415450aeed81ea52a8b35c09b6f) Merge branch 'dev' into validate-rag-urls
### 📊 Changes
**2 files changed** (+17 additions, -4 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/retrieval/web/main.py` (+4 -0)
📝 `backend/open_webui/retrieval/web/utils.py` (+13 -4)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [ ] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- I have been experiencing the issue "Oops! The URL you provided is invalid. Please double-check and try again."
- It is a result of Searxng returning invalid urls as part of the search results. For example, I saw a URL that had a malformed query string (no =value after the ?query)
- This PR only allows valid URLs to be used during a web search
### Added
- None
### Changed
- None
### Deprecated
- None
### Removed
- None
### Fixed
- Prevent invalid URLs from being loaded by the RAG web loader
### Security
- None
### Breaking Changes
- None
---
### Additional Information
- This code was separated from https://github.com/open-webui/open-webui/pull/9263 - I've tested them individually, but they are intended to go together. There are going to be merge conflicts when merging them together - please use "safe_urls" as the inputs to the web loader when resolving these conflicts.
- There are some people experiencing this issue inside of https://github.com/open-webui/open-webui/issues/8074
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/9314
Author: @roryeckel
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @tjbck
Base:
dev← Head:validate-rag-urls📝 Commits (4)
121a13dfix: Filter to valid RAG web search URLs3db6b43fix: Filter out invalid RAG web URLs (continued)310a18eMerge branch 'dev' into validate-rag-urls1a1cc15Merge branch 'dev' into validate-rag-urls📊 Changes
2 files changed (+17 additions, -4 deletions)
View changed files
📝
backend/open_webui/retrieval/web/main.py(+4 -0)📝
backend/open_webui/retrieval/web/utils.py(+13 -4)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.