github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-08-30 17:25:30 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3020] [CLOSED] fix: Fixed docs dir in UI (DISCARD. Missed changing the target branch. Recreated #3021 with correct target branch) #124819

New Issue
Closed
opened 2026-05-21 04:55:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 04:55:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/3020
Author: @CristianVladescu
Created: 6/11/2024
Status: ❌ Closed

Base: main ← Head: fix-docs-dir-in-ui

📝 Commits (10+)

📊 Changes

73 files changed (+2395 additions, -135 deletions)

View changed files

📝 backend/apps/rag/main.py (+50 -2)
📝 backend/apps/rag/utils.py (+2 -12)
➕ backend/apps/webui/internal/migrations/012_add_tools.py (+61 -0)
📝 backend/apps/webui/main.py (+5 -2)
➕ backend/apps/webui/models/tools.py (+131 -0)
📝 backend/apps/webui/routers/chats.py (+1 -1)
➕ backend/apps/webui/routers/tools.py (+178 -0)
📝 backend/apps/webui/routers/utils.py (+17 -0)
➕ backend/apps/webui/utils.py (+23 -0)
📝 backend/config.py (+24 -1)
📝 backend/constants.py (+1 -0)
📝 backend/main.py (+182 -19)
📝 backend/utils/task.py (+5 -0)
➕ backend/utils/tools.py (+73 -0)
📝 package-lock.json (+194 -7)
📝 package.json (+4 -0)
📝 src/app.css (+21 -0)
➕ src/lib/apis/tools/index.ts (+193 -0)
📝 src/lib/apis/utils/index.ts (+33 -0)
📝 src/lib/components/admin/Settings/Documents.svelte (+43 -2)

...and 53 more files

📄 Description

DISCARD. Missed changing the target branch. Recreated #3021 with correct target branch

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Under admin/settings/documents section, the DOCS_DIR is statically shown as /data/docs when in fact the dafault value is /app/backend/data/docs, misleading the user to the wrong path he has to mount. Also, if the DOCS_DIR is provided in the ENV vars, again, the value won't be reflected in UI

Added

  • Added DOCS_FILE_INCLUDE_FILTER_LIST and DOCS_FILE_EXCLUDE_FILTER_LIST to further enhance the Docs scanning functionality, also configurable from the admin documents settings UI

Changed

  • get_rag_config() now returns the value of DOCS_DIR so it can be shown in the admin documents settings UI dynamically

Fixed

  • Actual value of DOCS_DIR shown in admin documents settings UI

Screenshots or Videos

Screenshot from 2024-06-11 13-13-56

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/3020 **Author:** [@CristianVladescu](https://github.com/CristianVladescu) **Created:** 6/11/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-docs-dir-in-ui` --- ### 📝 Commits (10+) - [`54bbfa5`](https://github.com/open-webui/open-webui/commit/54bbfa5e89ccfd59d8a92ca6888afde8404067d4) chore: npm - [`5a3736f`](https://github.com/open-webui/open-webui/commit/5a3736f1ee2c91359b1bb966c7866f1d9819acd8) feat: tools page - [`8ad52f0`](https://github.com/open-webui/open-webui/commit/8ad52f0fccf3e3a93c5e1d8f37c8372c5a75d361) feat: code editor - [`f2bd3fd`](https://github.com/open-webui/open-webui/commit/f2bd3fdf1988e04302b8796b2503363794683a10) chore: rm console log - [`dd423f4`](https://github.com/open-webui/open-webui/commit/dd423f43de095174ab900606959ec1a7c369df37) feat: default tools template - [`fb0f106`](https://github.com/open-webui/open-webui/commit/fb0f106afed467e8a6caa43bab089306c332bc35) refac: styling - [`8b1e2ce`](https://github.com/open-webui/open-webui/commit/8b1e2ce2795b753778ca5d6408a05fc7ed0adcbb) feat: code format - [`12a04b1`](https://github.com/open-webui/open-webui/commit/12a04b118f58d59c38d0e11835a0958e525165a1) refac: styling - [`f43b545`](https://github.com/open-webui/open-webui/commit/f43b545bdd6261d8a4e04c5c00a7ca8b21c74105) refac - [`6e7e575`](https://github.com/open-webui/open-webui/commit/6e7e575a18848aee64b1913fd76bee0a3190fc60) refac ### 📊 Changes **73 files changed** (+2395 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/rag/main.py` (+50 -2) 📝 `backend/apps/rag/utils.py` (+2 -12) ➕ `backend/apps/webui/internal/migrations/012_add_tools.py` (+61 -0) 📝 `backend/apps/webui/main.py` (+5 -2) ➕ `backend/apps/webui/models/tools.py` (+131 -0) 📝 `backend/apps/webui/routers/chats.py` (+1 -1) ➕ `backend/apps/webui/routers/tools.py` (+178 -0) 📝 `backend/apps/webui/routers/utils.py` (+17 -0) ➕ `backend/apps/webui/utils.py` (+23 -0) 📝 `backend/config.py` (+24 -1) 📝 `backend/constants.py` (+1 -0) 📝 `backend/main.py` (+182 -19) 📝 `backend/utils/task.py` (+5 -0) ➕ `backend/utils/tools.py` (+73 -0) 📝 `package-lock.json` (+194 -7) 📝 `package.json` (+4 -0) 📝 `src/app.css` (+21 -0) ➕ `src/lib/apis/tools/index.ts` (+193 -0) 📝 `src/lib/apis/utils/index.ts` (+33 -0) 📝 `src/lib/components/admin/Settings/Documents.svelte` (+43 -2) _...and 53 more files_ </details> ### 📄 Description DISCARD. Missed changing the target branch. Recreated #3021 with correct target branch # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Under admin/settings/documents section, the DOCS_DIR is statically shown as `/data/docs` when in fact the dafault value is `/app/backend/data/docs`, misleading the user to the wrong path he has to mount. Also, if the DOCS_DIR is provided in the ENV vars, again, the value won't be reflected in UI ### Added - Added `DOCS_FILE_INCLUDE_FILTER_LIST` and `DOCS_FILE_EXCLUDE_FILTER_LIST` to further enhance the Docs scanning functionality, also configurable from the admin documents settings UI ### Changed - `get_rag_config()` now returns the value of DOCS_DIR so it can be shown in the admin documents settings UI dynamically ### Fixed - Actual value of DOCS_DIR shown in admin documents settings UI --- ### Screenshots or Videos ![Screenshot from 2024-06-11 13-13-56](https://github.com/open-webui/open-webui/assets/13788125/ed6909f7-d99f-4ac2-bf6d-17ce9f5d4364) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 04:55:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#124819