github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-06-03 23:38:13 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2263] [CLOSED] Fix/share chat reactive loop #124603

New Issue
Closed
opened 2026-05-21 04:39:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 04:39:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2263
Author: @jonathan-rohde
Created: 5/14/2024
Status: ❌ Closed

Base: main ← Head: fix/share-chat-reactive-loop

📝 Commits (10+)

📊 Changes

64 files changed (+3145 additions, -1444 deletions)

View changed files

📝 .github/pull_request_template.md (+32 -19)
📝 .prettierignore (+302 -6)
📝 Dockerfile (+4 -2)
📝 backend/apps/audio/main.py (+20 -19)
📝 backend/apps/images/main.py (+89 -68)
📝 backend/apps/litellm/main.py (+11 -8)
📝 backend/apps/ollama/main.py (+29 -25)
📝 backend/apps/openai/main.py (+28 -19)
📝 backend/apps/rag/main.py (+126 -107)
📝 backend/apps/web/main.py (+13 -9)
📝 backend/apps/web/routers/auths.py (+16 -16)
📝 backend/apps/web/routers/chats.py (+2 -2)
📝 backend/apps/web/routers/configs.py (+4 -4)
📝 backend/apps/web/routers/users.py (+3 -3)
📝 backend/config.py (+278 -73)
📝 backend/main.py (+42 -39)
📝 cypress/e2e/chat.cy.ts (+33 -0)
📝 docker-compose.api.yaml (+0 -2)
📝 docker-compose.data.yaml (+0 -2)
📝 docker-compose.gpu.yaml (+0 -2)

...and 44 more files

📄 Description

Pull Request Checklist

  • Target branch: Pull requests should target the dev branch.
  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for the changes?
  • Code Review: Have you self-reviewed your code and addressed any coding standard issues?

Description

When you open the share modal dialog, the event loop causes a flood of requests to the backend. It is caused by the change of the variable chat, which cause a revalidate of the component and loading the same data again from backend.

Changelog Entry

Fixed

  • Request flood, when create the chat share link

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2263 **Author:** [@jonathan-rohde](https://github.com/jonathan-rohde) **Created:** 5/14/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/share-chat-reactive-loop` --- ### 📝 Commits (10+) - [`b3c5ebb`](https://github.com/open-webui/open-webui/commit/b3c5ebb323fc4efa134dea05189270b5fe66a404) Updated uk-UA/translation.json - [`685ee9b`](https://github.com/open-webui/open-webui/commit/685ee9b71471018af01fabb58e609747084da63f) chore: format - [`df3675a`](https://github.com/open-webui/open-webui/commit/df3675aaf7d12ec384b37bf6b7cc05d9063e4f3c) Merge pull request #2104 from Silentoplayz/translation-update - [`1d9c745`](https://github.com/open-webui/open-webui/commit/1d9c745b35048ff0a04b08da42c2c9d0e1021dcb) fix: replace deprecated on_event with lifespan - [`038b6af`](https://github.com/open-webui/open-webui/commit/038b6af8137f38c34f38937d13a6fbe507129ed9) refac: user menu - [`c1fc7bc`](https://github.com/open-webui/open-webui/commit/c1fc7bc764cdaaccfbb2cd8c68a1fcd38923b7e2) fix: citation styling - [`9a95767`](https://github.com/open-webui/open-webui/commit/9a95767062f0ec600fc9a001055789cc52dbb66c) Merge branch 'dev' of https://github.com/open-webui/open-webui into dev - [`93aea0a`](https://github.com/open-webui/open-webui/commit/93aea0a4d4d05ec841bacf446be971a397e66914) Removed version synatax as its no longer needed per Docker Docs - [`ef8070d`](https://github.com/open-webui/open-webui/commit/ef8070d35dd5980aa92e7d6d4a9d66b0b16f7cf5) added healthcheck - [`a374405`](https://github.com/open-webui/open-webui/commit/a37440591147a4b1e2e122fb339bc47cbd9ac94f) 🎖️Added translations for Citation and No source available ### 📊 Changes **64 files changed** (+3145 additions, -1444 deletions) <details> <summary>View changed files</summary> 📝 `.github/pull_request_template.md` (+32 -19) 📝 `.prettierignore` (+302 -6) 📝 `Dockerfile` (+4 -2) 📝 `backend/apps/audio/main.py` (+20 -19) 📝 `backend/apps/images/main.py` (+89 -68) 📝 `backend/apps/litellm/main.py` (+11 -8) 📝 `backend/apps/ollama/main.py` (+29 -25) 📝 `backend/apps/openai/main.py` (+28 -19) 📝 `backend/apps/rag/main.py` (+126 -107) 📝 `backend/apps/web/main.py` (+13 -9) 📝 `backend/apps/web/routers/auths.py` (+16 -16) 📝 `backend/apps/web/routers/chats.py` (+2 -2) 📝 `backend/apps/web/routers/configs.py` (+4 -4) 📝 `backend/apps/web/routers/users.py` (+3 -3) 📝 `backend/config.py` (+278 -73) 📝 `backend/main.py` (+42 -39) 📝 `cypress/e2e/chat.cy.ts` (+33 -0) 📝 `docker-compose.api.yaml` (+0 -2) 📝 `docker-compose.data.yaml` (+0 -2) 📝 `docker-compose.gpu.yaml` (+0 -2) _...and 44 more files_ </details> ### 📄 Description ## Pull Request Checklist - [x] **Target branch:** Pull requests should target the `dev` branch. - [x] **Description:** Briefly describe the changes in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for the changes? - [x] **Code Review:** Have you self-reviewed your code and addressed any coding standard issues? --- ## Description When you open the share modal dialog, the event loop causes a flood of requests to the backend. It is caused by the change of the variable *chat*, which cause a revalidate of the component and loading the same data again from backend. --- ### Changelog Entry ### Fixed - Request flood, when create the chat share link --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 04:39:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#124603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?