github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-15 21:19:39 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #19039] [CLOSED] fix+feat: NOTES: Fix broken message submission to completions endpoint AND improve edit feature #11869

New Issue
Closed
opened 2025-11-11 19:59:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 19:59:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19039
Author: @Classic298
Created: 11/8/2025
Status: ❌ Closed

Base: dev ← Head: fix+feat-note-chat-editor

📝 Commits (3)

  • 7ee9b00 Implement message cleaning before API call
  • c149dcf Update Chat.svelte
  • 9ececd9 Fix duplicate content and data declaration in submitHandler

📊 Changes

1 file changed (+20 additions, -1 deletions)

View changed files

📝 src/lib/components/notes/NoteEditor/Chat.svelte (+20 -1)

📄 Description

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction

Changelog Entry

Description

This PR fixes a bug in the Notes Chat feature that caused 400 Bad Request errors when sending messages to AI models. The issue was caused by internal UI state fields being incorrectly included in API requests. Additionally, implements a safety check to prevent accidental full-note rewrites when edit mode is enabled without text selection.

Root Cause:* The Notes Chat feature was creating placeholder assistant messages with internal UI state fields (done: false) for streaming response management. These messages were being sent directly to the API without sanitization, violating the OpenAI message format specification.

Solution: Implemented a message cleaning pipeline that:

  1. Filters out empty assistant messages used as UI placeholders
  2. Maps messages to only include standard OpenAI fields (role, content, and optionally name)
  3. Removes all internal state management fields before API transmission

UX Improvement: Added edit mode validation to prevent confusion where users enable edit mode without selecting text, which would result in the AI rewriting the entire note. Users must now either:

  • Select specific text to edit, or
  • Use CTRL+A to explicitly select the entire note for rewriting

Added

  • Validation check requiring text selection when edit mode is enabled in Notes Chat
  • User-friendly toast notification prompting users to select text before editing the Note

"Only allow editing of the note if anything is selected - to edit the entire note, CTRL+A should be used - uninformed users or new users might be confused and enable the edit button and then accidentally have the AI rewrite the entire note. If the entire note should be rewritten, CTRL+A should be used - if edit mode is turned on and nothing is selected, the user should be informed that he needs to select a text which should be edited." - https://github.com/open-webui/open-webui/issues/13464#issuecomment-3092376920

Changed

  • Refactored message preparation to filter out empty assistant messages and internal UI fields before API calls
  • Messages are now cleaned to only include OpenAI-compliant fields (role, content, name)
  • Fixed potential issue where users could accidentally rewrite entire notes without explicit selection (CTRL+A now required for full-note edits)

Video

Screencast_20251108_145845.webm

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19039 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 11/8/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix+feat-note-chat-editor` --- ### 📝 Commits (3) - [`7ee9b00`](https://github.com/open-webui/open-webui/commit/7ee9b0090af5cc77f2fd6a3bb8f6dbe70bf6f06f) Implement message cleaning before API call - [`c149dcf`](https://github.com/open-webui/open-webui/commit/c149dcfc7f03acd01228e42344e5e5a9542ae893) Update Chat.svelte - [`9ececd9`](https://github.com/open-webui/open-webui/commit/9ececd97699e0dbf855b767ae07de44ddeb519c0) Fix duplicate content and data declaration in submitHandler ### 📊 Changes **1 file changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/notes/NoteEditor/Chat.svelte` (+20 -1) </details> ### 📄 Description **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction # Changelog Entry ### Description This PR fixes a bug in the Notes Chat feature that caused 400 Bad Request errors when sending messages to AI models. The issue was caused by internal UI state fields being incorrectly included in API requests. Additionally, implements a safety check to prevent accidental full-note rewrites when edit mode is enabled without text selection. *Root Cause:** The Notes Chat feature was creating placeholder assistant messages with internal UI state fields (`done: false`) for streaming response management. These messages were being sent directly to the API without sanitization, violating the OpenAI message format specification. **Solution:** Implemented a message cleaning pipeline that: 1. Filters out empty assistant messages used as UI placeholders 2. Maps messages to only include standard OpenAI fields (role, content, and optionally name) 3. Removes all internal state management fields before API transmission **UX Improvement:** Added edit mode validation to prevent confusion where users enable edit mode without selecting text, which would result in the AI rewriting the entire note. Users must now either: - Select specific text to edit, or - Use CTRL+A to explicitly select the entire note for rewriting ### Added - Validation check requiring text selection when edit mode is enabled in Notes Chat - User-friendly toast notification prompting users to select text before editing the Note > "Only allow editing of the note if anything is selected - to edit the entire note, CTRL+A should be used - uninformed users or new users might be confused and enable the edit button and then accidentally have the AI rewrite the entire note. If the entire note should be rewritten, CTRL+A should be used - if edit mode is turned on and nothing is selected, the user should be informed that he needs to select a text which should be edited." - https://github.com/open-webui/open-webui/issues/13464#issuecomment-3092376920 ### Changed - Refactored message preparation to filter out empty assistant messages and internal UI fields before API calls - Messages are now cleaned to only include OpenAI-compliant fields (role, content, name) - Fixed potential issue where users could accidentally rewrite entire notes without explicit selection (CTRL+A now required for full-note edits) --- ## Video [Screencast_20251108_145845.webm](https://github.com/user-attachments/assets/1d9ef6aa-04e0-46ca-a6cb-fb6c70ffdff7) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 19:59:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#11869
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?