[PR #18880] [CLOSED] **feat** Add docling-core dependency and validate DoclingDocument responses #11808

New Issue

GiteaMirror · 2025-11-11T19:57:38-06:00

GiteaMirror commented

2025-11-11 19:57:38 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18880
Author: @mingxzhao
Created: 11/3/2025
Status: ❌ Closed

Base: dev ← Head: reqfix

📝 Commits (3)

14b5dd3 Add docling-core dependency and validate DoclingDocument responses
4e32c68 revert DOclingDocument import to 1.x docling-core version as OpenWebUI still targets Docling Serve v1
c112143 Merge branch 'dev' into reqfix

📊 Changes

3 files changed (+25 additions, -1 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/main.py (+23 -1)
📝 backend/requirements.txt (+1 -0)
📝 pyproject.toml (+1 -0)

📄 Description

Added docling-core as dependency so validator is available at runtime

Docling loader now validates REST response using DoclingDocument

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

[ x] Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
[ x] Description: Provide a concise description of the changes made in this pull request.
[ x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ x] Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
[ x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[ x] Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
[ x] Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
[ x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[ x] Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Validate Docling API responses with Docling’s Pydantic models and install the core dependency so the loader can safely export markdown.

Added

docling-core dependency to backend requirements.

Changed

Docling loader now parses REST responses into DoclingDocument, exports markdown, and falls back gracefully on validation/export errors.

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

[List any fixes, corrections, or bug fixes]

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18880 **Author:** [@mingxzhao](https://github.com/mingxzhao) **Created:** 11/3/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `reqfix` --- ### 📝 Commits (3) - [`14b5dd3`](https://github.com/open-webui/open-webui/commit/14b5dd3850cee9470a9f065080d340a184136a5a) Add docling-core dependency and validate DoclingDocument responses - [`4e32c68`](https://github.com/open-webui/open-webui/commit/4e32c680d9016755ff410b1b99249badac454c2b) revert DOclingDocument import to 1.x docling-core version as OpenWebUI still targets Docling Serve v1 - [`c112143`](https://github.com/open-webui/open-webui/commit/c112143a578da6d7549991276125179b2726db4d) Merge branch 'dev' into reqfix ### 📊 Changes **3 files changed** (+25 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/main.py` (+23 -1) 📝 `backend/requirements.txt` (+1 -0) 📝 `pyproject.toml` (+1 -0) </details> ### 📄 Description Added docling-core as dependency so validator is available at runtime Docling loader now validates REST response using DoclingDocument # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [ x] **Description:** Provide a concise description of the changes made in this pull request. - [ x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [ x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [ x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [ x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Validate Docling API responses with Docling’s Pydantic models and install the core dependency so the loader can safely export markdown. ### Added - docling-core dependency to backend requirements. - ### Changed - Docling loader now parses REST responses into DoclingDocument, exports markdown, and falls back gracefully on validation/export errors. - ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:57:38 -06:00

GiteaMirror closed this issue

2025-11-11 19:57:38 -06:00

GiteaMirror referenced this issue

2026-04-20 04:24:20 -05:00

[PR #11808] [MERGED] FIX #5682 dates not surviving importing #22795

GiteaMirror referenced this issue

2026-04-25 11:27:07 -05:00

[PR #11808] [MERGED] FIX #5682 dates not surviving importing #38425

GiteaMirror referenced this issue

2026-04-29 20:25:52 -05:00

[PR #11808] [MERGED] FIX #5682 dates not surviving importing #45843