[PR #18841] [MERGED] fix: duplicate prompt suggestions freezes webpage #11786

New Issue

GiteaMirror · 2025-11-11T19:57:04-06:00

GiteaMirror commented

2025-11-11 19:57:04 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18841
Author: @acomarcho
Created: 11/1/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @tjbck

Base: dev ← Head: fix/duplicate-prompt-suggestions-freezes-webpage

📝 Commits (1)

da282ce fix: duplicate prompt suggestions freezes webpage

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/components/chat/Suggestions.svelte (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fixes this issue reported in https://github.com/open-webui/open-webui/issues/18566
Now, duplicate prompt contents won't freeze the page.

Added

None

Changed

Gave each filteredPrompt an unique composite key of content and index.

Deprecated

None

Removed

None

Fixed

This PR fixes this issue reported in https://github.com/open-webui/open-webui/issues/18566

Security

None

Breaking Changes

None

Additional Information

This PR fixes this issue reported in https://github.com/open-webui/open-webui/issues/18566

Ideally, we'd have a unique ID stored as the backend so the frontend reconciliation can be done better. This will need some sort of backend migration.

But, it's probably going to be a short list of data anyways, so I believe this quick fix from the frontend side should suffice.

We are not just using indexes because that could be problematic when reconciliation occurs, so a composite key of content + idx is used this way.

Screenshots or Videos

Page now renders properly when we have the same prompt content.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18841 **Author:** [@acomarcho](https://github.com/acomarcho) **Created:** 11/1/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/duplicate-prompt-suggestions-freezes-webpage` --- ### 📝 Commits (1) - [`da282ce`](https://github.com/open-webui/open-webui/commit/da282ce5c7ee1b9783f96e556bf45b8107b663e6) fix: duplicate prompt suggestions freezes webpage ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Suggestions.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR fixes this issue reported in https://github.com/open-webui/open-webui/issues/18566 Now, duplicate prompt contents won't freeze the page. ### Added None ### Changed Gave each filteredPrompt an unique composite key of content and index. ### Deprecated None ### Removed None ### Fixed This PR fixes this issue reported in https://github.com/open-webui/open-webui/issues/18566 ### Security None ### Breaking Changes None --- ### Additional Information This PR fixes this issue reported in https://github.com/open-webui/open-webui/issues/18566 **Ideally, we'd have a unique ID stored as the backend so the frontend reconciliation can be done better. This will need some sort of backend migration**. But, it's probably going to be a short list of data anyways, so I believe this quick fix from the frontend side should suffice. We are not **just using indexes** because that could be problematic when reconciliation occurs, so a composite key of content + idx is used this way. ### Screenshots or Videos <img width="806" height="360" alt="image" src="https://github.com/user-attachments/assets/f2d53e1f-5aa5-4718-bb3f-3c83c62416b9" /> Page now renders properly when we have the same prompt content. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:57:04 -06:00

GiteaMirror closed this issue

2025-11-11 19:57:04 -06:00

GiteaMirror referenced this issue

2026-04-20 04:24:11 -05:00

[PR #11786] [MERGED] fix: Better visibility for scroll bar in webkit browsers #22792

GiteaMirror referenced this issue

2026-04-25 11:27:03 -05:00

[PR #11786] [MERGED] fix: Better visibility for scroll bar in webkit browsers #38422

GiteaMirror referenced this issue

2026-04-29 20:25:37 -05:00

[PR #11786] [MERGED] fix: Better visibility for scroll bar in webkit browsers #45840