github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 19:08:59 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #18757] [CLOSED] fix(notes): resolve dark mode PDF rendering inconsistency between /notes and /notes/:uuid pages #11705

New Issue
Closed
opened 2025-11-11 19:39:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 19:39:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18757
Author: @acomarcho
Created: 10/31/2025
Status: ❌ Closed

Base: dev ← Head: fix/pdf-download-from-notes-list-does-not-apply-dark-mode-styling

📝 Commits (1)

  • d07ff49 fix(notes): resolve dark mode PDF rendering inconsistency between /notes and /notes/:uuid pages

📊 Changes

3 files changed (+132 additions, -183 deletions)

View changed files

📝 src/lib/components/notes/NoteEditor.svelte (+1 -110)
📝 src/lib/components/notes/Notes.svelte (+9 -73)
➕ src/lib/utils/pdf-generator.ts (+122 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Create shared pdf-generator utility to eliminate code duplication
  • Fix /notes page PDF generation to properly detect and apply dark mode
  • Ensure consistent PDF formatting across all note download locations
  • Add txt download support to Notes.svelte for feature parity

This PR fixes issue: https://github.com/open-webui/open-webui/issues/18526

Added

None

Changed

  • Introduced a new shared function to generate the PDF, instead of having to maintain two different functions.

Deprecated

None

Removed

None

Fixed

  • Fix /notes page PDF generation to properly detect and apply dark mode
  • Ensure consistent PDF formatting across all note download locations
  • Add txt download support to Notes.svelte for feature parity

Security

None

Breaking Changes

None

Additional Information

Solves issue https://github.com/open-webui/open-webui/issues/18526

Screenshots or Videos

Example run in dark mode:

https://github.com/user-attachments/assets/10353089-9921-4deb-b5e3-67a08ea68f61

Example run in light mode:

https://github.com/user-attachments/assets/77e98300-c248-4a59-b046-d2efed9a659f

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18757 **Author:** [@acomarcho](https://github.com/acomarcho) **Created:** 10/31/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/pdf-download-from-notes-list-does-not-apply-dark-mode-styling` --- ### 📝 Commits (1) - [`d07ff49`](https://github.com/open-webui/open-webui/commit/d07ff493cfd11a08fc12759c20a14a5ad31629e8) fix(notes): resolve dark mode PDF rendering inconsistency between /notes and /notes/:uuid pages ### 📊 Changes **3 files changed** (+132 additions, -183 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/notes/NoteEditor.svelte` (+1 -110) 📝 `src/lib/components/notes/Notes.svelte` (+9 -73) ➕ `src/lib/utils/pdf-generator.ts` (+122 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [x] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Create shared pdf-generator utility to eliminate code duplication - Fix /notes page PDF generation to properly detect and apply dark mode - Ensure consistent PDF formatting across all note download locations - Add txt download support to Notes.svelte for feature parity This PR fixes issue: https://github.com/open-webui/open-webui/issues/18526 ### Added None ### Changed - Introduced a new shared function to generate the PDF, instead of having to maintain two different functions. ### Deprecated None ### Removed None ### Fixed - Fix /notes page PDF generation to properly detect and apply dark mode - Ensure consistent PDF formatting across all note download locations - Add txt download support to Notes.svelte for feature parity ### Security None ### Breaking Changes None --- ### Additional Information Solves issue https://github.com/open-webui/open-webui/issues/18526 ### Screenshots or Videos Example run in dark mode: https://github.com/user-attachments/assets/10353089-9921-4deb-b5e3-67a08ea68f61 Example run in light mode: https://github.com/user-attachments/assets/77e98300-c248-4a59-b046-d2efed9a659f ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 19:39:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#11705
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?