[PR #24778] refactor: remove unused GET /evaluations/feedbacks/all endpoint #115145

Open
opened 2026-05-18 16:06:15 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24778
Author: @Classic298
Created: 5/15/2026
Status: 🔄 Open

Base: devHead: remove-unused-feedbacks-all-endpoint


📝 Commits (1)

  • ca5304d refactor: remove unused GET /evaluations/feedbacks/all endpoint

📊 Changes

2 files changed (+0 additions, -38 deletions)

View changed files

📝 backend/open_webui/routers/evaluations.py (+0 -7)
📝 src/lib/apis/evaluations/index.ts (+0 -31)

📄 Description

GET /evaluations/feedbacks/all returned the entire feedback table in a single response (flagged as a Medium OOM risk for admins in open-webui#22206). Its only frontend wrapper, getAllFeedbacks in src/lib/apis/evaluations/index.ts, is dead: nothing imports or calls it anywhere in the codebase. The endpoint is a redundant view-only twin of GET /evaluations/feedbacks/all/export, which is what the admin Feedbacks UI actually uses.

Removes the endpoint, the now-unused FeedbackResponse import in the evaluations router, and the dead getAllFeedbacks frontend wrapper. The shared Feedbacks.get_all_feedbacks data-layer method is kept, since the live /feedbacks/all/export endpoint still uses it.

Ref: open-webui#22206

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24778 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/15/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `remove-unused-feedbacks-all-endpoint` --- ### 📝 Commits (1) - [`ca5304d`](https://github.com/open-webui/open-webui/commit/ca5304d901ae0293c055fcc3525b6584e26fb588) refactor: remove unused GET /evaluations/feedbacks/all endpoint ### 📊 Changes **2 files changed** (+0 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/evaluations.py` (+0 -7) 📝 `src/lib/apis/evaluations/index.ts` (+0 -31) </details> ### 📄 Description GET /evaluations/feedbacks/all returned the entire feedback table in a single response (flagged as a Medium OOM risk for admins in open-webui#22206). Its only frontend wrapper, getAllFeedbacks in src/lib/apis/evaluations/index.ts, is dead: nothing imports or calls it anywhere in the codebase. The endpoint is a redundant view-only twin of GET /evaluations/feedbacks/all/export, which is what the admin Feedbacks UI actually uses. Removes the endpoint, the now-unused FeedbackResponse import in the evaluations router, and the dead getAllFeedbacks frontend wrapper. The shared Feedbacks.get_all_feedbacks data-layer method is kept, since the live /feedbacks/all/export endpoint still uses it. Ref: open-webui#22206 ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-18 16:06:15 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#115145