[PR #24712] fix: handle list-shape data in Firecrawl /search response #115107

New Issue

GiteaMirror · 2026-05-18T16:03:48-05:00

GiteaMirror commented

2026-05-18 16:03:48 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24712
Author: @Classic298
Created: 5/14/2026
Status: 🔄 Open

Base: dev ← Head: fix/firecrawl-list-shape-parsing

📝 Commits (1)

eabf630 fix: handle list-shape data in Firecrawl /search response

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 backend/open_webui/retrieval/web/firecrawl.py (+4 -1)

📄 Description

Firecrawl /search returns either {"data": [...]} (flat list — v1, and what frost19k reported on #23966) or {"data": {"web": [...]}} (v2, current production). The parser only handled the dict shape:

data = response.get('data') or {}
results = data.get('web') or []

On a list-shape response, data.get('web') raised AttributeError, caught by the function's outer try/except, and search_firecrawl silently returned []. Web search worked against v2 endpoints but is one upstream-format-change away from failing closed again. Accept either.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24712 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/14/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/firecrawl-list-shape-parsing` --- ### 📝 Commits (1) - [`eabf630`](https://github.com/open-webui/open-webui/commit/eabf63072b433ccaa0444875bf453d6408d63225) fix: handle list-shape data in Firecrawl /search response ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/firecrawl.py` (+4 -1) </details> ### 📄 Description Firecrawl /search returns either `{"data": [...]}` (flat list — v1, and what frost19k reported on #23966) or `{"data": {"web": [...]}}` (v2, current production). The parser only handled the dict shape: data = response.get('data') or {} results = data.get('web') or [] On a list-shape response, `data.get('web')` raised AttributeError, caught by the function's outer try/except, and `search_firecrawl` silently returned []. Web search worked against v2 endpoints but is one upstream-format-change away from failing closed again. Accept either. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 16:03:48 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#115107