[PR #24556] [CLOSED] fix: handle None chat_id in get_event_emitter channel-mode check #115033

New Issue

GiteaMirror · 2026-05-18T15:57:43-05:00

GiteaMirror commented

2026-05-18 15:57:43 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24556
Author: @Classic298
Created: 5/10/2026
Status: ❌ Closed

Base: dev ← Head: fix/chat-completions-nonetype-channel-check

📝 Commits (1)

06f8ee0 fix: handle None chat_id in get_event_emitter channel-mode check

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 backend/open_webui/socket/main.py (+3 -2)

📄 Description

Direct API callers to /api/chat/completions pass no chat_id, so metadata['chat_id'] ends up None. dict.get('chat_id', '') returns None (not '') when the key is present-with-None, so the channels-streaming branch added in v0.9.5 (0037baeb2) crashed with 'NoneType' object has no attribute 'startswith', surfacing as HTTP 400 to the caller.

Fixes #24553.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24556 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/10/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/chat-completions-nonetype-channel-check` --- ### 📝 Commits (1) - [`06f8ee0`](https://github.com/open-webui/open-webui/commit/06f8ee0e423c46e98f4a9beb9b07a3bcfd0bc031) fix: handle None chat_id in get_event_emitter channel-mode check ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/socket/main.py` (+3 -2) </details> ### 📄 Description Direct API callers to /api/chat/completions pass no chat_id, so metadata['chat_id'] ends up None. dict.get('chat_id', '') returns None (not '') when the key is present-with-None, so the channels-streaming branch added in v0.9.5 (0037baeb2) crashed with 'NoneType' object has no attribute 'startswith', surfacing as HTTP 400 to the caller. Fixes #24553. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 15:57:43 -05:00

GiteaMirror closed this issue

2026-05-18 15:57:46 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#115033