[PR #24548] fix: gate OAuth profile picture MIME at ingestion + storage layer #115029

New Issue

GiteaMirror · 2026-05-18T15:57:35-05:00

GiteaMirror commented

2026-05-18 15:57:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24548
Author: @Classic298
Created: 5/10/2026
Status: 🔄 Open

Base: dev ← Head: fix/oauth-picture-mime-and-storage-validator

📝 Commits (1)

5e7244a fix: gate OAuth profile picture MIME at ingestion + storage layer

📊 Changes

2 files changed (+36 additions, -9 deletions)

View changed files

📝 backend/open_webui/models/users.py (+13 -0)
📝 backend/open_webui/utils/oauth.py (+23 -9)

📄 Description

process_picture_url (utils/oauth.py): MIME was inferred from the URL extension via mimetypes.guess_type, the upstream Content-Type was discarded, and there was no allowlist. An SVG picture URL produced data:image/svg+xml;base64,... in the user's profile_image_url. Switch to the upstream Content-Type and gate it against PROFILE_IMAGE_ALLOWED_MIME_TYPES (the same env var the serving endpoint already uses); fall back to /user.png if the MIME isn't in the allowlist. Also pass allow_redirects=AIOHTTP_CLIENT ALLOW_REDIRECTS on the aiohttp session.get — the existing validate_url() only checks the initial URL, redirects to internal targets would otherwise still be followed (same class as the rh5x-h6pp-cjj6 cluster, sixth call site).
update_user_profile_image_url_by_id (models/users.py): SQLAlchemy write path bypassed the Pydantic form validators, so anything stored via OAuth or any other non-form caller landed in the column unchallenged. Run validate_profile_image_url at the storage layer before the assignment.
insert_new_user (models/users.py): same gap on the new-user path used by Auths.insert_new_auth (OAuth signup, LDAP). Same storage-layer call to validate_profile_image_url, falling back to /user.png if the supplied value doesn't pass.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24548 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/10/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/oauth-picture-mime-and-storage-validator` --- ### 📝 Commits (1) - [`5e7244a`](https://github.com/open-webui/open-webui/commit/5e7244ab8bb35d709b3757da2d6d2dec6f6bf30e) fix: gate OAuth profile picture MIME at ingestion + storage layer ### 📊 Changes **2 files changed** (+36 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/users.py` (+13 -0) 📝 `backend/open_webui/utils/oauth.py` (+23 -9) </details> ### 📄 Description 1. _process_picture_url (utils/oauth.py): MIME was inferred from the URL extension via mimetypes.guess_type, the upstream Content-Type was discarded, and there was no allowlist. An SVG picture URL produced data:image/svg+xml;base64,... in the user's profile_image_url. Switch to the upstream Content-Type and gate it against PROFILE_IMAGE_ALLOWED_MIME_TYPES (the same env var the serving endpoint already uses); fall back to /user.png if the MIME isn't in the allowlist. Also pass allow_redirects=AIOHTTP_CLIENT_ ALLOW_REDIRECTS on the aiohttp session.get — the existing validate_url() only checks the initial URL, redirects to internal targets would otherwise still be followed (same class as the rh5x-h6pp-cjj6 cluster, sixth call site). 2. update_user_profile_image_url_by_id (models/users.py): SQLAlchemy write path bypassed the Pydantic form validators, so anything stored via OAuth or any other non-form caller landed in the column unchallenged. Run validate_profile_image_url at the storage layer before the assignment. 3. insert_new_user (models/users.py): same gap on the new-user path used by Auths.insert_new_auth (OAuth signup, LDAP). Same storage-layer call to validate_profile_image_url, falling back to /user.png if the supplied value doesn't pass. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 15:57:35 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#115029