[PR #24521] [MERGED] fix: require write permission for pin_channel_message on standard channels #115014

New Issue

GiteaMirror · 2026-05-18T15:56:18-05:00

GiteaMirror commented

2026-05-18 15:56:18 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24521
Author: @Classic298
Created: 5/9/2026
Status: ✅ Merged
Merged: 5/10/2026
Merged by: @tjbck

Base: dev ← Head: fix/channels-pin-write-permission

📝 Commits (1)

184d2a9 fix: require write permission for pin_channel_message on standard channels

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/channels.py (+2 -1)

📄 Description

pin_channel_message (channels.py:1242) checked permission='read' on the standard-channel branch before mutating is_pinned / pinned_by / pinned_at via Messages.update_is_pinned_by_id. Pin/unpin is a write operation; gating it on read access let any user with read-only channel access pin or unpin any message in the channel, including admin posts.

One-character fix: change permission='read' to permission='write'.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24521 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/9/2026 **Status:** ✅ Merged **Merged:** 5/10/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/channels-pin-write-permission` --- ### 📝 Commits (1) - [`184d2a9`](https://github.com/open-webui/open-webui/commit/184d2a96f0b158b1ce5b0c9045fda684d193bd39) fix: require write permission for pin_channel_message on standard channels ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/channels.py` (+2 -1) </details> ### 📄 Description `pin_channel_message` (channels.py:1242) checked `permission='read'` on the standard-channel branch before mutating `is_pinned` / `pinned_by` / `pinned_at` via `Messages.update_is_pinned_by_id`. Pin/unpin is a write operation; gating it on read access let any user with read-only channel access pin or unpin any message in the channel, including admin posts. One-character fix: change `permission='read'` to `permission='write'`. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 15:56:18 -05:00

GiteaMirror closed this issue

2026-05-18 15:56:22 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#115014