[PR #24486] [MERGED] fix: notes is_pinned TypeError on create/get #114985

New Issue

GiteaMirror · 2026-05-18T15:53:22-05:00

GiteaMirror commented

2026-05-18 15:53:22 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24486
Author: @Classic298
Created: 5/9/2026
Status: ✅ Merged
Merged: 5/9/2026
Merged by: @tjbck

Base: dev ← Head: fix/notes-is-pinned-typeerror

📝 Commits (1)

3612151 fix: notes is_pinned TypeError on create/get

📊 Changes

2 files changed (+5 additions, -2 deletions)

View changed files

📝 backend/open_webui/models/notes.py (+1 -1)
📝 backend/open_webui/routers/notes.py (+4 -1)

📄 Description

is_pinned exists on the NoteModel pydantic schema but not on the Note SQLAlchemy table (pinning lives in PinnedNote). Two call sites broke after the split:

models/notes.py: insert_new_note passed model_dump() straight into Note(...), causing 'is_pinned' is an invalid keyword argument for Note.
routers/notes.py: get_note_by_id passed is_pinned twice to NoteResponse (once via model_dump default, once explicitly), causing got multiple values for keyword argument 'is_pinned'.

Exclude is_pinned from the dump on insert, and override it via dict-spread on the response (matching the pattern already used elsewhere in the same router).

Fixes #24484

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24486 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/9/2026 **Status:** ✅ Merged **Merged:** 5/9/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/notes-is-pinned-typeerror` --- ### 📝 Commits (1) - [`3612151`](https://github.com/open-webui/open-webui/commit/36121511a0875c4ab7e5a9347af15d0ccce808c1) fix: notes is_pinned TypeError on create/get ### 📊 Changes **2 files changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/notes.py` (+1 -1) 📝 `backend/open_webui/routers/notes.py` (+4 -1) </details> ### 📄 Description is_pinned exists on the NoteModel pydantic schema but not on the Note SQLAlchemy table (pinning lives in PinnedNote). Two call sites broke after the split: - models/notes.py: insert_new_note passed model_dump() straight into Note(...), causing 'is_pinned' is an invalid keyword argument for Note. - routers/notes.py: get_note_by_id passed is_pinned twice to NoteResponse (once via model_dump default, once explicitly), causing got multiple values for keyword argument 'is_pinned'. Exclude is_pinned from the dump on insert, and override it via dict-spread on the response (matching the pattern already used elsewhere in the same router). Fixes #24484 ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 15:53:22 -05:00

GiteaMirror closed this issue

2026-05-18 15:53:25 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#114985