github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-15 12:36:27 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #24011] [MERGED] perf: improve splash LCP image discovery in app.html #114784

New Issue
Closed
opened 2026-05-18 15:37:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-18 15:37:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24011
Author: @jmleksan
Created: 4/22/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @tjbck

Base: dev ← Head: perf/splash-preload

📝 Commits (1)

  • 8c84667 Enhance image loading performance by adding preload links and setting loading attributes for logos in app.html

📊 Changes

1 file changed (+14 additions, -0 deletions)

View changed files

📝 src/app.html (+14 -0)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Not needed (no new env vars, public APIs, or deployment changes).
  • Dependencies: No new or upgraded dependencies.
  • Testing: Manual tests performed (see below); verified splash behavior and Lighthouse/LCP guidance around splash image discovery.
  • Agentic AI Code: This change has been human-reviewed and manually tested.
  • Code review: Self-reviewed for scope and consistency with existing app.html splash behavior.
  • Design & Architecture: No new settings; only adjusts how the existing splash logo is loaded.
  • Git Hygiene: Atomic PR (splash/LCP loading only), rebased on dev.
  • Title Prefix: perf

Changelog Entry

Description

Improve first-load LCP for the splash screen by making the splash logo URL discoverable earlier from the initial HTML and by avoiding deferred image loading behavior.

  • Adds a theme-resolved <link rel="preload" as="image"> for the active splash asset (/static/splash-dark.png vs /static/splash.png) with fetchpriority="high", inserted from the existing inline theme bootstrap script in src/app.html.
  • Ensures splash images explicitly use eager loading and high fetch priority where applicable (including the dynamically inserted #logo image and the #logo-her markup path).

Motivation: Lighthouse/LCP audits flag late discovery when the LCP image request is not visible in the initial document and/or is not prioritized like other above-the-fold content.

Added

  • Theme-resolved splash image preload in src/app.html (as="image", fetchpriority="high").

Changed

  • src/app.html
    • Splash logo loading hints updated to prioritize the LCP candidate and avoid lazy-loading patterns.
    • Preload targets only the splash variant selected by the resolved theme class logic (reduces unused preload warnings vs preloading both assets).

Fixed

  • Browser console warnings related to preload request mode mismatch (e.g., crossorigin on preload not matching the eventual image request) by aligning preload attributes with the actual image fetch mode.

Additional Information

Manual testing

  • Cold load with dark theme: splash shows correct asset; verify splash image is requested early; no preload mismatch warnings.
  • Cold load with light theme: same checks for /static/splash.png.
  • her theme path: confirm existing splash behavior remains correct (this change should not alter her splash logic beyond loading hints on shared markup where applied).
  • Lighthouse/PageSpeed: confirm “LCP request discovery” guidance is addressed for the splash image (or materially improved), understanding remaining LCP time may still include render/main-thread components unrelated to image fetch.

Screenshots or Videos

image

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24011 **Author:** [@jmleksan](https://github.com/jmleksan) **Created:** 4/22/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `perf/splash-preload` --- ### 📝 Commits (1) - [`8c84667`](https://github.com/open-webui/open-webui/commit/8c846676d5d41ac7b2c8c92553f84eacc090a89d) Enhance image loading performance by adding preload links and setting loading attributes for logos in app.html ### 📊 Changes **1 file changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/app.html` (+14 -0) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist <!-- ### ⚠️ Important: Your PR is a contribution, not a guarantee of merge. The most impactful way to contribute to Open WebUI is through well-written bug reports, detailed feature discussions, and thoughtful ideas. These directly shape the project. If you do open a pull request, please know that Open WebUI is held to the highest standard of code quality, consistency, and architectural coherence, and every line merged becomes something the core team must own, maintain, and support indefinitely. Submitted code may be refactored, rewritten, or used as inspiration for a different implementation. This is not a reflection of your work's quality. It is how we ensure that a small team can deeply understand and evolve every part of the codebase. --> **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Not needed (no new env vars, public APIs, or deployment changes). - [x] **Dependencies:** No new or upgraded dependencies. - [x] **Testing:** Manual tests performed (see below); verified splash behavior and Lighthouse/LCP guidance around splash image discovery. - [x] **Agentic AI Code:** This change has been human-reviewed and manually tested. - [x] **Code review:** Self-reviewed for scope and consistency with existing `app.html` splash behavior. - [x] **Design & Architecture:** No new settings; only adjusts how the existing splash logo is loaded. - [x] **Git Hygiene:** Atomic PR (splash/LCP loading only), rebased on `dev`. - [x] **Title Prefix:** `perf` # Changelog Entry ### Description Improve first-load **LCP** for the splash screen by making the splash logo URL **discoverable earlier** from the initial HTML and by avoiding deferred image loading behavior. - Adds a **theme-resolved** `<link rel="preload" as="image">` for the active splash asset (`/static/splash-dark.png` vs `/static/splash.png`) with **`fetchpriority="high"`**, inserted from the existing inline theme bootstrap script in `src/app.html`. - Ensures splash images explicitly use **eager loading** and **high fetch priority** where applicable (including the dynamically inserted `#logo` image and the `#logo-her` markup path). Motivation: Lighthouse/LCP audits flag late discovery when the LCP image request is not visible in the initial document and/or is not prioritized like other above-the-fold content. ### Added - Theme-resolved splash image preload in `src/app.html` (`as="image"`, `fetchpriority="high"`). ### Changed - `src/app.html` - Splash logo loading hints updated to prioritize the LCP candidate and avoid lazy-loading patterns. - Preload targets only the splash variant selected by the resolved theme class logic (reduces unused preload warnings vs preloading both assets). ### Fixed - Browser console warnings related to **preload request mode mismatch** (e.g., `crossorigin` on preload not matching the eventual image request) by aligning preload attributes with the actual image fetch mode. --- ### Additional Information **Manual testing** - Cold load with **dark** theme: splash shows correct asset; verify splash image is requested early; no preload mismatch warnings. - Cold load with **light** theme: same checks for `/static/splash.png`. - **`her` theme path**: confirm existing splash behavior remains correct (this change should not alter `her` splash logic beyond loading hints on shared markup where applied). - Lighthouse/PageSpeed: confirm “LCP request discovery” guidance is addressed for the splash image (or materially improved), understanding remaining LCP time may still include render/main-thread components unrelated to image fetch. ### Screenshots or Videos <img width="329" height="249" alt="image" src="https://github.com/user-attachments/assets/fb2a5ccf-4932-49b8-902b-4758acab0489" /> ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-18 15:37:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#114784
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?