[PR #18108] [MERGED] fix: "Cannot handle batch sizes > 1 if no padding token is defined" for some reranking models #11469

New Issue

GiteaMirror · 2025-11-11T19:32:39-06:00

GiteaMirror commented

2025-11-11 19:32:39 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18108
Author: @YetheSamartaka
Created: 10/7/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @tjbck

Base: dev ← Head: main

📝 Commits (1)

f69426f Fixed: Cannot handle batch sizes > 1 if no padding token is defined

📊 Changes

1 file changed (+16 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/retrieval.py (+16 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixes "Cannot handle batch sizes > 1 if no padding token is defined" for some reranking models.

For reranker models that do not have this defined in their config by using the eos_token_id if present as pad_token_id.

Can be tested on https://huggingface.co/Qwen/Qwen3-Reranker-0.6B where before this change, it was not working at all and now it is working as supposed

It resolves this issue outlined in this discussion:
https://github.com/open-webui/open-webui/discussions/16027

Fixed

"Cannot handle batch sizes > 1 if no padding token is defined" for some reranking models

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18108 **Author:** [@YetheSamartaka](https://github.com/YetheSamartaka) **Created:** 10/7/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (1) - [`f69426f`](https://github.com/open-webui/open-webui/commit/f69426fd77f0a6965d7779f86a9b724fdde22219) Fixed: Cannot handle batch sizes > 1 if no padding token is defined ### 📊 Changes **1 file changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/retrieval.py` (+16 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Fixes "Cannot handle batch sizes > 1 if no padding token is defined" for some reranking models. For reranker models that do not have this defined in their config by using the eos_token_id if present as pad_token_id. Can be tested on https://huggingface.co/Qwen/Qwen3-Reranker-0.6B where before this change, it was not working at all and now it is working as supposed It resolves this issue outlined in this discussion: https://github.com/open-webui/open-webui/discussions/16027 ### Fixed - "Cannot handle batch sizes > 1 if no padding token is defined" for some reranking models ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:32:39 -06:00

GiteaMirror closed this issue

2025-11-11 19:32:40 -06:00

GiteaMirror referenced this issue

2026-04-19 22:13:52 -05:00

[GH-ISSUE #11469] feat: Add Non-Intrusive System Monitoring Widget to Display CPU, GPU, and Memory Usage in Web Interface #16242

GiteaMirror referenced this issue

2026-04-25 05:40:33 -05:00

[GH-ISSUE #11469] feat: Add Non-Intrusive System Monitoring Widget to Display CPU, GPU, and Memory Usage in Web Interface #31771

GiteaMirror referenced this issue

2026-05-05 16:51:54 -05:00

[GH-ISSUE #11469] feat: Add Non-Intrusive System Monitoring Widget to Display CPU, GPU, and Memory Usage in Web Interface #54908