github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 14:39:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #23783] [CLOSED] fix: Correct the OAuth2.1 static flow #114677

New Issue
Closed
opened 2026-05-18 15:29:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-18 15:29:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23783
Author: @DonMul
Created: 4/16/2026
Status: ❌ Closed

Base: dev ← Head: fixOauth2.1Static

📝 Commits (3)

  • 5dc19c1 fix: Correct the OAuth2.1 static flow
  • b88c49b ran ruff over the changed files for oauth2.1 static fixing
  • b1fdd8d Correct code styling of AddToolServerModal.svelte

📊 Changes

4 files changed (+48 additions, -27 deletions)

View changed files

📝 backend/open_webui/routers/configs.py (+7 -1)
📝 backend/open_webui/utils/oauth.py (+37 -25)
📝 src/lib/apis/configs/index.ts (+1 -0)
📝 src/lib/components/AddToolServerModal.svelte (+3 -1)

📄 Description

Changelog Entry

Description

The OAuth2.1 Static workflow was not working as intended. Somewhere in the conversion of the Static OAuth2.1 authentication for MCP servers Pull Request there was some lost in translation issues i believe (because the original Pull Request has some different functionality than what has been merged. This Pull Request is intended to correct the issues.

Fixed

  • Fix the authentication flow for OAuth2.1 Static authentication for MCP servers

Additional Information

The intended flow for Static OAuth2.1 credentials is as following:

  1. The user gets the static client_id and client_secret from the provider of the MCP server

  2. The user will enter these in the current modal box to manage the MCP server (see below)
    Screenshot 2026-04-14 at 13 31 04

  3. The user can (optionally) verify the connection, but Must (not optional) register the client. This client will ALWAYS make use of the entered client_id and client_secret

  4. Whenever the user selects/enables the tool server in his/her chat, the user will be redirected to the authentication page of the MCP provider
    Screenshot 2026-04-14 at 13 25 54

  5. The MCP provider will do a callback to the oauth client callback URL. For the example in the screenshots above, that would be http://localhost:3000/oauth/clients/mcp:udemy/callback. It is possible that this callback URL needs to be configured on the side of the MCP provider as well.

  6. The MCP server will then be enabled for the user and can be queried accordingly
    Screenshot 2026-04-14 at 13 35 33

Please let me know if there are any unclarities about this feature, i am more than willing to help!

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23783 **Author:** [@DonMul](https://github.com/DonMul) **Created:** 4/16/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fixOauth2.1Static` --- ### 📝 Commits (3) - [`5dc19c1`](https://github.com/open-webui/open-webui/commit/5dc19c1ba09c4fa39d654b30337adb0fba1b9aca) fix: Correct the OAuth2.1 static flow - [`b88c49b`](https://github.com/open-webui/open-webui/commit/b88c49b67524c7d86327c6c1015e0c98dbf8963b) ran ruff over the changed files for oauth2.1 static fixing - [`b1fdd8d`](https://github.com/open-webui/open-webui/commit/b1fdd8d1bebc385863bec168af36efc64e28f34d) Correct code styling of AddToolServerModal.svelte ### 📊 Changes **4 files changed** (+48 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/configs.py` (+7 -1) 📝 `backend/open_webui/utils/oauth.py` (+37 -25) 📝 `src/lib/apis/configs/index.ts` (+1 -0) 📝 `src/lib/components/AddToolServerModal.svelte` (+3 -1) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Changelog Entry ### Description The OAuth2.1 Static workflow was not working as intended. Somewhere in the conversion of the Static OAuth2.1 authentication for MCP servers Pull Request there was some lost in translation issues i believe (because the original [Pull Request](https://github.com/open-webui/open-webui/pull/22266/changes) has some different functionality than what has been [merged](https://github.com/open-webui/open-webui/commit/601bb783587a3e965cf88c148e4856b988655b13). This Pull Request is intended to correct the issues. ### Fixed - Fix the authentication flow for OAuth2.1 Static authentication for MCP servers --- ### Additional Information The intended flow for Static OAuth2.1 credentials is as following: 1. The user gets the static `client_id` and `client_secret` from the provider of the MCP server 2. The user will enter these in the current modal box to manage the MCP server (see below) <img width="479" height="562" alt="Screenshot 2026-04-14 at 13 31 04" src="https://github.com/user-attachments/assets/ce91857a-c6fd-4dec-8d8b-e0629de63064" /> 3. The user can (optionally) verify the connection, but Must (not optional) register the client. This client will ALWAYS make use of the entered client_id and client_secret 4. Whenever the user selects/enables the tool server in his/her chat, the user will be redirected to the authentication page of the MCP provider <img width="392" height="254" alt="Screenshot 2026-04-14 at 13 25 54" src="https://github.com/user-attachments/assets/c9a8bfab-051d-4515-9faf-5430edc4df49" /> 5. The MCP provider will do a callback to the oauth client callback URL. For the example in the screenshots above, that would be `http://localhost:3000/oauth/clients/mcp:udemy/callback`. It is possible that this callback URL needs to be configured on the side of the MCP provider as well. 6. The MCP server will then be enabled for the user and can be queried accordingly <img width="1050" height="371" alt="Screenshot 2026-04-14 at 13 35 33" src="https://github.com/user-attachments/assets/d936e94e-fe10-4bae-a20b-a6c90d386bcb" /> Please let me know if there are any unclarities about this feature, i am more than willing to help! <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-18 15:29:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#114677
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?