[PR #23642] [MERGED] fix: invalidate stale Socket.IO sessions on role change and user deletion #114608

New Issue

GiteaMirror · 2026-05-18T15:24:52-05:00

GiteaMirror commented

2026-05-18 15:24:52 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23642
Author: @Classic298
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @tjbck

Base: dev ← Head: fix/stale-session-pool-role

📝 Commits (1)

7612bac fix: invalidate stale Socket.IO sessions on role change and user deletion

📊 Changes

2 files changed (+24 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/users.py (+6 -0)
📝 backend/open_webui/socket/main.py (+18 -0)

📄 Description

SESSION_POOL caches user.role at connection time and never refreshes it. When an admin demotes or deletes a user, their socket sessions retain the old cached role until voluntary disconnect, allowing continued use of admin-gated socket features (ydoc editing, channel access).

Adds disconnect_user_sessions() helper that disconnects all sockets for a user ID. Called from update_user_by_id (on role change) and delete_user_by_id. The client auto-reconnects and re-authenticates with fresh DB data.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23642 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/stale-session-pool-role` --- ### 📝 Commits (1) - [`7612bac`](https://github.com/open-webui/open-webui/commit/7612bac9d4526444e2e4ab40b27cebdf525182ad) fix: invalidate stale Socket.IO sessions on role change and user deletion ### 📊 Changes **2 files changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/users.py` (+6 -0) 📝 `backend/open_webui/socket/main.py` (+18 -0) </details> ### 📄 Description SESSION_POOL caches user.role at connection time and never refreshes it. When an admin demotes or deletes a user, their socket sessions retain the old cached role until voluntary disconnect, allowing continued use of admin-gated socket features (ydoc editing, channel access). Adds disconnect_user_sessions() helper that disconnects all sockets for a user ID. Called from update_user_by_id (on role change) and delete_user_by_id. The client auto-reconnects and re-authenticates with fresh DB data. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 15:24:52 -05:00

GiteaMirror closed this issue

2026-05-18 15:24:55 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#114608