[PR #23633] [MERGED] fix: reject empty passwords in LDAP authentication to prevent unauthenticated binds #114600

New Issue

GiteaMirror · 2026-05-18T15:24:17-05:00

GiteaMirror commented

2026-05-18 15:24:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23633
Author: @Classic298
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @tjbck

Base: dev ← Head: fix/ldap-empty-password-bypass

📝 Commits (1)

0dbb60b fix: reject empty passwords in LDAP authentication to prevent unauthenticated binds

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+8 -0)

📄 Description

Per RFC 4513, a Simple Bind with a non-empty DN but empty password is unauthenticated simple authentication. Many LDAP servers (OpenLDAP default, some AD configs) accept these binds, allowing account takeover without valid credentials.

Rejects empty and whitespace-only passwords before attempting the LDAP bind.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23633 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/ldap-empty-password-bypass` --- ### 📝 Commits (1) - [`0dbb60b`](https://github.com/open-webui/open-webui/commit/0dbb60bc45cda772f67fe7f22742f8aa7ad172a7) fix: reject empty passwords in LDAP authentication to prevent unauthenticated binds ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+8 -0) </details> ### 📄 Description Per RFC 4513, a Simple Bind with a non-empty DN but empty password is unauthenticated simple authentication. Many LDAP servers (OpenLDAP default, some AD configs) accept these binds, allowing account takeover without valid credentials. Rejects empty and whitespace-only passwords before attempting the LDAP bind. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 15:24:17 -05:00

GiteaMirror closed this issue

2026-05-18 15:24:21 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#114600