github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #17850] [MERGED] chore: Remove unused parameter definitions #11373

New Issue
Closed
opened 2025-11-11 19:30:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 19:30:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17850
Author: @silentoplayz
Created: 9/28/2025
Status: ✅ Merged
Merged: 9/28/2025
Merged by: @tjbck

Base: dev ← Head: remove-unused-params

📝 Commits (1)

  • 670dfca remove: used advanced params

📊 Changes

2 files changed (+0 additions, -13 deletions)

View changed files

📝 backend/open_webui/utils/misc.py (+0 -7)
📝 backend/open_webui/utils/payload.py (+0 -6)

📄 Description

Pull Request Checklist

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This pull request cleans up unused parameter definitions related to model configuration in misc.py and payload.py.

Removed

  • The following parameters are removed from the expected configuration in parse_ollama_modelfile in misc.py:

    • "typical_p"
    • "penalize_newline"
    • "numa"
    • "main_gpu"
    • "low_vram"
    • "f16_kv"
    • "vocab_only"

  • Several parameters are removed from the transformation logic in apply_model_params_to_body_ollama in payload.py, including:

    • "typical_p"
    • "penalize_newline"
    • "numa"
    • "main_gpu"
    • "low_vram"
    • "vocab_only"

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17850 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 9/28/2025 **Status:** ✅ Merged **Merged:** 9/28/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `remove-unused-params` --- ### 📝 Commits (1) - [`670dfca`](https://github.com/open-webui/open-webui/commit/670dfca6a80aa6c12a4f64888b4f09eed6cb20c4) remove: used advanced params ### 📊 Changes **2 files changed** (+0 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/misc.py` (+0 -7) 📝 `backend/open_webui/utils/payload.py` (+0 -6) </details> ### 📄 Description # Pull Request Checklist - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request cleans up unused parameter definitions related to model configuration in `misc.py` and `payload.py`. ### Removed - The following parameters are removed from the expected configuration in `parse_ollama_modelfile` in `misc.py`: - `"typical_p"` - `"penalize_newline"` - `"numa"` - `"main_gpu"` - `"low_vram"` - `"f16_kv"` - `"vocab_only"` - Several parameters are removed from the transformation logic in `apply_model_params_to_body_ollama` in `payload.py`, including: - `"typical_p"` - `"penalize_newline"` - `"numa"` - `"main_gpu"` - `"low_vram"` - `"vocab_only"` ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 19:30:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#11373
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?