github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 11:28:35 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #17832] [MERGED] fix: pinned chats not updating after archiving all chats #11364

New Issue
Closed
opened 2025-11-11 19:29:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 19:29:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17832
Author: @silentoplayz
Created: 9/28/2025
Status: ✅ Merged
Merged: 9/28/2025
Merged by: @tjbck

Base: dev ← Head: pinned-chats-not-updating

📝 Commits (1)

  • 2b5dca2 fix: pinned chats not updating after archiving all chats

📊 Changes

1 file changed (+12 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/DataControls.svelte (+12 -2)

📄 Description

Pull Request Checklist

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Fixes a UI bug where pinned chats would remain visible in the sidebar after all chats were archived from the "Data Controls" settings menu. This change ensures that the UI correctly reflects the updated state of pinned chats.

Changed

  • The archiveAllChatsHandler function now clears the pinnedChats store after successfully archiving all chats.

Fixed

  • Resolved an issue where the pinned chats list in the sidebar was not being updated after all chats were archived, which previously required a page refresh to see the correct state.

Additional Information

  • This change ensures UI consistency by directly updating the frontend's pinnedChats store to match the backend state after the archive operation is complete.

Screenshots or Videos

Before the fix applied (After archiving all chats):
image

After the fix has been applied (After archiving all chats):
image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17832 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 9/28/2025 **Status:** ✅ Merged **Merged:** 9/28/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `pinned-chats-not-updating` --- ### 📝 Commits (1) - [`2b5dca2`](https://github.com/open-webui/open-webui/commit/2b5dca2929892d80a30cbad62fbf0c9be46e416e) fix: pinned chats not updating after archiving all chats ### 📊 Changes **1 file changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/DataControls.svelte` (+12 -2) </details> ### 📄 Description # Pull Request Checklist - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixes a UI bug where pinned chats would remain visible in the sidebar after all chats were archived from the "Data Controls" settings menu. This change ensures that the UI correctly reflects the updated state of pinned chats. ### Changed - The `archiveAllChatsHandler` function now clears the `pinnedChats` store after successfully archiving all chats. ### Fixed - Resolved an issue where the pinned chats list in the sidebar was not being updated after all chats were archived, which previously required a page refresh to see the correct state. ### Additional Information - This change ensures UI consistency by directly updating the frontend's `pinnedChats` store to match the backend state after the archive operation is complete. ### Screenshots or Videos **Before the fix applied (After archiving all chats):** <img width="261" height="1268" alt="image" src="https://github.com/user-attachments/assets/d440bc91-f364-4778-a94f-b4e969982171" /> **After the fix has been applied (After archiving all chats):** <img width="261" height="1268" alt="image" src="https://github.com/user-attachments/assets/b487c344-5c63-4d6b-a5de-422c8cb63ac2" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 19:29:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#11364
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?