[PR #17823] [MERGED] fix: correct messageId parameter in createMessagesList call #11359

New Issue

GiteaMirror · 2025-11-11T19:29:42-06:00

GiteaMirror commented

2025-11-11 19:29:42 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17823
Author: @ITOTI-Y
Created: 9/27/2025
Status: ✅ Merged
Merged: 9/28/2025
Merged by: @tjbck

Base: dev ← Head: main

📝 Commits (1)

68a4fdf fix: correct messageId parameter in createMessagesList call

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/components/chat/Messages/ContentRenderer.svelte (+1 -1)

📄 Description

Fix FloatingButtons component to use messageId instead of id

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The previous call to createMessagesList misused the variable {id}, preventing the floating button from establishing context. This has been corrected; the floating button now accurately retrieves context using {messageId}.

Changed

Updated assignment for messages parameter (changing parameter id to messageId):
messages={createMessagesList(history, id)} -> messages={createMessagesList(history, messageId)}

Fixed

Fix floating buttons not getting context

Screenshots or Videos

Before the fix is applied
After the fix is applied

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17823 **Author:** [@ITOTI-Y](https://github.com/ITOTI-Y) **Created:** 9/27/2025 **Status:** ✅ Merged **Merged:** 9/28/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (1) - [`68a4fdf`](https://github.com/open-webui/open-webui/commit/68a4fdf0e95f09abe021f7950b23052afa579714) fix: correct messageId parameter in createMessagesList call ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ContentRenderer.svelte` (+1 -1) </details> ### 📄 Description - Fix FloatingButtons component to use messageId instead of id # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - The previous call to `createMessagesList` misused the variable `{id}`, preventing the floating button from establishing context. This has been corrected; the floating button now accurately retrieves context using `{messageId}`. ### Changed - Updated assignment for `messages` parameter (changing parameter `id` to `messageId`): `messages={createMessagesList(history, id)}` -> `messages={createMessagesList(history, messageId)}` ### Fixed - Fix floating buttons not getting context ### Screenshots or Videos - **Before the fix is applied** <img width="1171" height="737" alt="image" src="https://github.com/user-attachments/assets/e8c5efbd-04ea-44e3-b926-7967ccac5174" /> - **After the fix is applied** <img width="1175" height="806" alt="image" src="https://github.com/user-attachments/assets/d9ab8404-308f-4b83-bafe-8b045e44cc9a" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:29:42 -06:00

GiteaMirror closed this issue

2025-11-11 19:29:43 -06:00

GiteaMirror referenced this issue

2026-04-20 04:20:41 -05:00

[PR #11359] [CLOSED] i18n(common): add user language to prompt template #22714

GiteaMirror referenced this issue

2026-04-25 11:24:58 -05:00

[PR #11359] [CLOSED] i18n(common): add user language to prompt template #38344

GiteaMirror referenced this issue

2026-04-29 20:17:04 -05:00

[PR #11359] [CLOSED] i18n(common): add user language to prompt template #45762