[PR #17608] [MERGED] fix: prevent memory leaks in file handling and HTTP connections #11284

New Issue

GiteaMirror · 2025-11-11T19:27:35-06:00

GiteaMirror commented

2025-11-11 19:27:35 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17608
Author: @sihyeonn
Created: 9/19/2025
Status: ✅ Merged
Merged: 9/20/2025
Merged by: @tjbck

Base: dev ← Head: fix/sh-prevent-memory-leaks-on-ollama

📝 Commits (1)

7042318 fix: prevent memory leaks in file handling and HTTP connections

📊 Changes

1 file changed (+21 additions, -19 deletions)

View changed files

📝 backend/open_webui/routers/ollama.py (+21 -19)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed critical memory leaks in file handling during large file downloads
Improved HTTP connection management to prevent resource accumulation
Enhanced resource cleanup to ensure proper memory management

Added

Proper file handle management with explicit close/reopen pattern
requests.Session context manager for automatic connection cleanup
Connection timeout to prevent hanging requests

Changed

File handling in download_file_stream now properly closes file handles before hash calculation
HTTP requests now use session context managers for automatic cleanup
Removed unnecessary file.seek(0) after file reopening

Deprecated

None

Removed

Unnecessary file seek operations after file reopening
Implicit file handle management that could lead to memory leaks

Fixed

Memory leaks caused by unclosed file handles during file downloads
HTTP connection leaks from unmanaged requests sessions
Resource accumulation during large file processing operations

Security

None

Breaking Changes

None

Additional Information

This fix addresses a critical memory leak issue that could cause server memory to grow indefinitely during large file downloads
The changes ensure proper resource cleanup in all scenarios, including error conditions
Performance is improved by removing unnecessary file operations and ensuring connections are properly closed

Screenshots or Videos

Memory usage should remain stable during file downloads instead of continuously growing

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17608 **Author:** [@sihyeonn](https://github.com/sihyeonn) **Created:** 9/19/2025 **Status:** ✅ Merged **Merged:** 9/20/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/sh-prevent-memory-leaks-on-ollama` --- ### 📝 Commits (1) - [`7042318`](https://github.com/open-webui/open-webui/commit/7042318c3459f6c51b2015a0c43bb26324b0a644) fix: prevent memory leaks in file handling and HTTP connections ### 📊 Changes **1 file changed** (+21 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/ollama.py` (+21 -19) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed critical memory leaks in file handling during large file downloads - Improved HTTP connection management to prevent resource accumulation - Enhanced resource cleanup to ensure proper memory management ### Added - Proper file handle management with explicit close/reopen pattern - requests.Session context manager for automatic connection cleanup - Connection timeout to prevent hanging requests ### Changed - File handling in `download_file_stream` now properly closes file handles before hash calculation - HTTP requests now use session context managers for automatic cleanup - Removed unnecessary `file.seek(0)` after file reopening ### Deprecated - None ### Removed - Unnecessary file seek operations after file reopening - Implicit file handle management that could lead to memory leaks ### Fixed - Memory leaks caused by unclosed file handles during file downloads - HTTP connection leaks from unmanaged requests sessions - Resource accumulation during large file processing operations ### Security - None ### Breaking Changes - None --- ### Additional Information - This fix addresses a critical memory leak issue that could cause server memory to grow indefinitely during large file downloads - The changes ensure proper resource cleanup in all scenarios, including error conditions - Performance is improved by removing unnecessary file operations and ensuring connections are properly closed ### Screenshots or Videos - Memory usage should remain stable during file downloads instead of continuously growing ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:27:35 -06:00

GiteaMirror closed this issue

2025-11-11 19:27:36 -06:00

GiteaMirror referenced this issue

2026-04-19 22:10:59 -05:00

[GH-ISSUE #11284] issue: Cannot correctly handle the think tag of qwq model #16171

GiteaMirror referenced this issue

2026-04-25 05:36:06 -05:00

[GH-ISSUE #11284] issue: Cannot correctly handle the think tag of qwq model #31700

GiteaMirror referenced this issue

2026-05-05 16:47:13 -05:00

[GH-ISSUE #11284] issue: Cannot correctly handle the think tag of qwq model #54837