[PR #20258] [MERGED] feat: make changelog modal X button persist dismissal like "Okay, Let's Go!" button #112834

New Issue

GiteaMirror · 2026-05-18T13:02:40-05:00

GiteaMirror commented

2026-05-18 13:02:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20258
Author: @Classic298
Created: 12/30/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @tjbck

Base: dev ← Head: banner

📝 Commits (2)

d265606 Update ChangelogModal.svelte
932260c function

📊 Changes

1 file changed (+9 additions, -10 deletions)

View changed files

📝 src/lib/components/ChangelogModal.svelte (+9 -10)

📄 Description

Summary

The X (close) button on the "What's New" changelog modal now has the same behavior as the "Okay, Let's Go!" button, properly persisting the dismissal so the modal doesn't reappear until the next update.

This will kill some frustrations some users have who do not know these buttons behave differently, that keep on opening issues again and again because they do not know they need to click on "Okay, Let's Go!" for the modal to permanently disappear.

Problem

Previously, clicking the X button to close the changelog modal only set the version in localStorage and closed the modal. This was inconsistent with the "Okay, Let's Go!" button which also synced the version to user settings on the server. This could cause the modal to reappear unexpectedly in certain scenarios (e.g., clearing localStorage, logging in from another device).

Solution

Updated the X button click handler in ChangelogModal.svelte to match the "Okay, Let's Go!" button behavior:

Set version in localStorage
Update the settings store with the current version
Sync settings to the server via updateUserSettings API
Close the modal
This ensures both dismissal methods have consistent behavior.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20258 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/30/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `banner` --- ### 📝 Commits (2) - [`d265606`](https://github.com/open-webui/open-webui/commit/d265606dafc6180d9cf42a23311b77674473a874) Update ChangelogModal.svelte - [`932260c`](https://github.com/open-webui/open-webui/commit/932260c72efe1eca6dbdad107bcf5d6b1a4c3121) function ### 📊 Changes **1 file changed** (+9 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/ChangelogModal.svelte` (+9 -10) </details> ### 📄 Description ## Summary The X (close) button on the "What's New" changelog modal now has the same behavior as the "Okay, Let's Go!" button, properly persisting the dismissal so the modal doesn't reappear until the next update. This will kill some frustrations some users have who do not know these buttons behave differently, that keep on opening issues again and again because they do not know they need to click on "Okay, Let's Go!" for the modal to permanently disappear. ## Problem Previously, clicking the X button to close the changelog modal only set the version in localStorage and closed the modal. This was inconsistent with the "Okay, Let's Go!" button which also synced the version to user settings on the server. This could cause the modal to reappear unexpectedly in certain scenarios (e.g., clearing localStorage, logging in from another device). ## Solution Updated the X button click handler in ChangelogModal.svelte to match the "Okay, Let's Go!" button behavior: - Set version in localStorage - Update the settings store with the current version - Sync settings to the server via updateUserSettings API - Close the modal This ensures both dismissal methods have consistent behavior. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 13:02:40 -05:00

GiteaMirror closed this issue

2026-05-18 13:02:46 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#112834