[PR #17423] [MERGED] Fix file_handler filters #11222

New Issue

GiteaMirror · 2025-11-11T19:26:05-06:00

GiteaMirror commented

2025-11-11 19:26:05 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17423
Author: @aleprj
Created: 9/13/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @tjbck

Base: dev ← Head: fix-filehandler

📝 Commits (1)

f9fd22d fix: setting file_handler in a filter would generate errors in messages with no files, because a "files: Null" in metadata would trigger an attempt to delete a non existent files object

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 backend/open_webui/utils/filter.py (+5 -3)

📄 Description

Filters with file_hander would break when getting a message with no files, because a "files: Null" in metadata would trigger an attempt to delete a non existent files object

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed an issue when a filter with file_handler set received a message with no files.

Added

Changed

Deprecated

Removed

Fixed

Filters with file_handler set can handle messages with no files

Security

Breaking Changes

Additional Information

The metadata object would have a Files: Null object that would trigger the deletion of the other unchecked, causing an error that would return a "files" error to the user.

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17423 **Author:** [@aleprj](https://github.com/aleprj) **Created:** 9/13/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-filehandler` --- ### 📝 Commits (1) - [`f9fd22d`](https://github.com/open-webui/open-webui/commit/f9fd22d98e048e380208ab86bdee652e7794724c) fix: setting file_handler in a filter would generate errors in messages with no files, because a "files: Null" in metadata would trigger an attempt to delete a non existent files object ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/filter.py` (+5 -3) </details> ### 📄 Description Filters with file_hander would break when getting a message with no files, because a "files: Null" in metadata would trigger an attempt to delete a non existent files object # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed an issue when a filter with file_handler set received a message with no files. ### Added ### Changed ### Deprecated ### Removed ### Fixed - Filters with file_handler set can handle messages with no files ### Security ### Breaking Changes --- ### Additional Information - The metadata object would have a Files: Null object that would trigger the deletion of the other unchecked, causing an error that would return a "files" error to the user. ### Screenshots or Videos ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:26:05 -06:00

GiteaMirror closed this issue

2025-11-11 19:26:05 -06:00

GiteaMirror referenced this issue

2026-04-20 04:19:18 -05:00

[PR #11222] [CLOSED] [DRAFT][FIX] Jwt refresh flow #22690

GiteaMirror referenced this issue

2026-04-25 11:23:54 -05:00

[PR #11222] [CLOSED] [DRAFT][FIX] Jwt refresh flow #38320

GiteaMirror referenced this issue

2026-04-29 20:15:10 -05:00

[PR #11222] [CLOSED] [DRAFT][FIX] Jwt refresh flow #45738