github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-12 02:54:03 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #17567] [CLOSED] fix: OneDrive submenu overflow issue in attachment menu #111786

New Issue
Closed
opened 2026-05-18 11:45:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-18 11:45:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17567
Author: @vateseeb
Created: 9/18/2025
Status: ❌ Closed

Base: dev ← Head: fix/onedrive-submenu-overflow-17554

📝 Commits (2)

  • 39de109 fix: OneDrive submenu overflow issue in attachment menu
  • f73d7b0 Merge branch 'dev' into fix/onedrive-submenu-overflow-17554

📊 Changes

1 file changed (+79 additions, -53 deletions)

View changed files

📝 src/lib/components/chat/MessageInput/InputMenu.svelte (+79 -53)

📄 Description

Description

Fixes issue where OneDrive submenu was clipped within main attachment menu container, making submenu options not properly visible or accessible.

The previous implementation used DropdownMenu.Sub and DropdownMenu.SubContent which relied on CSS positioning that got clipped by the parent container with overflow-x-hidden.

Changes

  • Replace DropdownMenu.Sub/SubContent with tab-based navigation pattern
  • Use same approach as "Attach Notes", "Attach Knowledge", and "Reference Chats" menus
  • Add OneDrive tab with back navigation and slide transition
  • Maintain all existing OneDrive functionality and styling
  • Eliminate dependency on CSS overflow properties that caused clipping

Test Plan

  • Verify OneDrive menu item appears in attachment menu
  • Verify clicking OneDrive shows submenu with back navigation
  • Verify OneDrive personal and business options work correctly
  • Verify consistent UI behavior with other attachment menu tabs
  • Verify submenu is no longer clipped/hidden

Screenshots

Before: OneDrive submenu was clipped within main menu container
image

After: OneDrive submenu appears as a full tab view like other options
image
image

Fixes #17554

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17567 **Author:** [@vateseeb](https://github.com/vateseeb) **Created:** 9/18/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/onedrive-submenu-overflow-17554` --- ### 📝 Commits (2) - [`39de109`](https://github.com/open-webui/open-webui/commit/39de10934bd1488326148d62aca913925f1e3077) fix: OneDrive submenu overflow issue in attachment menu - [`f73d7b0`](https://github.com/open-webui/open-webui/commit/f73d7b00ffe92c1d20c2fa12781fe096c1760813) Merge branch 'dev' into fix/onedrive-submenu-overflow-17554 ### 📊 Changes **1 file changed** (+79 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/MessageInput/InputMenu.svelte` (+79 -53) </details> ### 📄 Description ## Description Fixes issue where OneDrive submenu was clipped within main attachment menu container, making submenu options not properly visible or accessible. The previous implementation used `DropdownMenu.Sub` and `DropdownMenu.SubContent` which relied on CSS positioning that got clipped by the parent container with `overflow-x-hidden`. ## Changes - Replace `DropdownMenu.Sub`/`SubContent` with tab-based navigation pattern - Use same approach as "Attach Notes", "Attach Knowledge", and "Reference Chats" menus - Add OneDrive tab with back navigation and slide transition - Maintain all existing OneDrive functionality and styling - Eliminate dependency on CSS overflow properties that caused clipping ## Test Plan - [x] Verify OneDrive menu item appears in attachment menu - [x] Verify clicking OneDrive shows submenu with back navigation - [x] Verify OneDrive personal and business options work correctly - [x] Verify consistent UI behavior with other attachment menu tabs - [x] Verify submenu is no longer clipped/hidden ## Screenshots Before: OneDrive submenu was clipped within main menu container <img width="280" height="203" alt="image" src="https://github.com/user-attachments/assets/8e584562-276f-4583-aa07-2d632b27f522" /> After: OneDrive submenu appears as a full tab view like other options <img width="237" height="143" alt="image" src="https://github.com/user-attachments/assets/646b1840-a49f-4713-8857-8cfccbe0af60" /> <img width="243" height="97" alt="image" src="https://github.com/user-attachments/assets/59d058dd-50cc-4ef4-8fae-59221e49f581" /> Fixes #17554 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-18 11:45:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#111786
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?