[PR #17273] [CLOSED] feat: add unified verifyConnection and enforce validation on submit #11173

New Issue

GiteaMirror · 2025-11-11T19:24:04-06:00

GiteaMirror commented

2025-11-11 19:24:04 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17273
Author: @acwoo97
Created: 9/8/2025
Status: ❌ Closed

Base: dev ← Head: feat/toast-error

📝 Commits (1)

53e72dc feat: add unified verifyConnection and enforce validation on submit

📊 Changes

1 file changed (+47 additions, -39 deletions)

View changed files

📝 src/lib/components/AddServerModal.svelte (+47 -39)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- feat: Introduces a new feature or enhancement to the codebase

Changelog Entry

Description

Refactored connection modal logic to enforce connection verification before saving.
Users can no longer save invalid or failing connections, improving reliability and preventing misconfigured entries.

Added

Unified verifyConnection function for consistent connection testing.

Changed

submitHandler now blocks saving if the connection verification fails.
Improved toast messages for both success and failure states.
Added extra logging for debugging connection test errors.

Deprecated

N/A

Removed

N/A

Fixed

Prevented invalid connections (e.g., wrong URL, missing credentials) from being saved without validation.

Security

Enforcing connection checks reduces risk of storing misconfigured or insecure connections.

Breaking Changes

None

Additional Information

This change enhances user experience and system stability by ensuring only valid connections can be saved.
No dependency changes introduced.
Related to improving external tool connection management.

Screenshots or Videos

N/A – no visual UI changes, only behavioral improvements when saving connections.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17273 **Author:** [@acwoo97](https://github.com/acwoo97) **Created:** 9/8/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/toast-error` --- ### 📝 Commits (1) - [`53e72dc`](https://github.com/open-webui/open-webui/commit/53e72dc0c77b2c455fb38cc7dae0bf5256e43c58) feat: add unified verifyConnection and enforce validation on submit ### 📊 Changes **1 file changed** (+47 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/AddServerModal.svelte` (+47 -39) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **feat**: Introduces a new feature or enhancement to the codebase # Changelog Entry ### Description - Refactored connection modal logic to enforce connection verification before saving. - Users can no longer save invalid or failing connections, improving reliability and preventing misconfigured entries. ### Added - Unified `verifyConnection` function for consistent connection testing. ### Changed - `submitHandler` now blocks saving if the connection verification fails. - Improved toast messages for both success and failure states. - Added extra logging for debugging connection test errors. ### Deprecated - N/A ### Removed - N/A ### Fixed - Prevented invalid connections (e.g., wrong URL, missing credentials) from being saved without validation. ### Security - Enforcing connection checks reduces risk of storing misconfigured or insecure connections. ### Breaking Changes - None --- ### Additional Information - This change enhances user experience and system stability by ensuring only valid connections can be saved. - No dependency changes introduced. - Related to improving external tool connection management. ### Screenshots or Videos N/A – no visual UI changes, only behavioral improvements when saving connections. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:24:04 -06:00

GiteaMirror closed this issue

2025-11-11 19:24:05 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#11173