[PR #16945] [CLOSED] fix: minor shell script fixes for more reliable execution #111598

New Issue

GiteaMirror · 2026-05-18T11:30:56-05:00

GiteaMirror commented

2026-05-18 11:30:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16945
Author: @silentoplayz
Created: 8/27/2025
Status: ❌ Closed

Base: dev ← Head: update-devsh

📝 Commits (5)

0ebacd3 fix: quote variables in backend/dev.sh to avoid word splitting & globbing
6d45ace refac: start.sh
1b214b9 refac: confirm_remove.sh
679b42e refac: run-ollama-docker.sh
703df8c refac: update_ollama_models.sh

📊 Changes

5 files changed (+41 additions, -23 deletions)

View changed files

📝 backend/dev.sh (+7 -1)
📝 backend/start.sh (+4 -2)
📝 confirm_remove.sh (+14 -12)
📝 run-ollama-docker.sh (+13 -5)
📝 update_ollama_models.sh (+3 -3)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Updated shell scripts used by the project to use a reliable shell shebang, added proper quoting for variable expansions, and cleaned up the command formatting. These changes prevent word‑splitting and accidental pathname expansion, making the development script more robust.

Changed

Added a shell shebang at the top line of the file.
Wrapped the $PORT variable in double quotes ("$PORT") to avoid word‑splitting when the variable is empty or contains spaces.
Quoted the asterisk argument ("*"), keeping the style consistent.
Reformatted the uvicorn command with line‑continuations for readability.

Fixed

Fixed a potential runtime issue where an unset or whitespace‑containing PORT variable could cause the script to fail or behave unexpectedly.
Prevented accidental glob expansion of the * argument passed to --forwarded-allow-ips.

Additional Information

The script continues to set CORS_ALLOW_ORIGIN to http://localhost:5173 for local development and runs the Uvicorn server on the supplied PORT (default 8080).
- No functional changes to the application’s behavior; only the script’s reliability is improved.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16945 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 8/27/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `update-devsh` --- ### 📝 Commits (5) - [`0ebacd3`](https://github.com/open-webui/open-webui/commit/0ebacd3541be7997596904f9a84efce539847d0e) fix: quote variables in backend/dev.sh to avoid word splitting & globbing - [`6d45ace`](https://github.com/open-webui/open-webui/commit/6d45aced7bb85c9d9a897a38fa5af47ce3495448) refac: start.sh - [`1b214b9`](https://github.com/open-webui/open-webui/commit/1b214b935df8b4dbf61e2de0aba88783c6dffd57) refac: confirm_remove.sh - [`679b42e`](https://github.com/open-webui/open-webui/commit/679b42e45332819413369011d640bddfa0b939f8) refac: run-ollama-docker.sh - [`703df8c`](https://github.com/open-webui/open-webui/commit/703df8c815a9dc732fe8fe84ea03860184ce8de4) refac: update_ollama_models.sh ### 📊 Changes **5 files changed** (+41 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `backend/dev.sh` (+7 -1) 📝 `backend/start.sh` (+4 -2) 📝 `confirm_remove.sh` (+14 -12) 📝 `run-ollama-docker.sh` (+13 -5) 📝 `update_ollama_models.sh` (+3 -3) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Updated shell scripts used by the project to use a reliable shell shebang, added proper quoting for variable expansions, and cleaned up the command formatting. These changes prevent word‑splitting and accidental pathname expansion, making the development script more robust. ### Changed - Added a shell shebang at the top line of the file. - Wrapped the `$PORT` variable in double quotes (`"$PORT"`) to avoid word‑splitting when the variable is empty or contains spaces. - Quoted the asterisk argument (`"*"`), keeping the style consistent. - Reformatted the `uvicorn` command with line‑continuations for readability. ### Fixed - Fixed a potential runtime issue where an unset or whitespace‑containing `PORT` variable could cause the script to fail or behave unexpectedly. - Prevented accidental glob expansion of the `*` argument passed to `--forwarded-allow-ips`. --- ### Additional Information - The script continues to set `CORS_ALLOW_ORIGIN` to `http://localhost:5173` for local development and runs the Uvicorn server on the supplied `PORT` (default 8080). - No functional changes to the application’s behavior; only the script’s reliability is improved. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 11:30:56 -05:00

GiteaMirror closed this issue

2026-05-18 11:30:59 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#111598