[PR #17137] [MERGED] fix: prevent double-save race by awaiting API calls and adding isSaving guard #11132

New Issue

GiteaMirror · 2025-11-11T19:22:58-06:00

GiteaMirror commented

2025-11-11 19:22:58 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17137
Author: @acwoo97
Created: 9/2/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @tjbck

Base: dev ← Head: feat/knowledge-update-race-condition

📝 Commits (1)

513cab9 fix: prevent double-save race by awaiting API calls and adding isSaving guard

📊 Changes

1 file changed (+35 additions, -25 deletions)

View changed files

📝 src/lib/components/workspace/Knowledge/KnowledgeBase.svelte (+35 -25)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Ensure file content update process is serialized by adding await and preventing race conditions.
Added isSaving guard to avoid multiple save requests triggered by rapid user actions.
Improved user experience by disabling the save button during in-flight save operations.

Added

isSaving state management for preventing duplicate save requests.

Changed

File update handler now uses await for updateFileDataContentById and updateFileFromKnowledgeById to enforce sequential execution.
Save button behavior adjusted to be disabled when a save operation is in progress.

Deprecated

N/A

Removed

N/A

Fixed

Fixed race condition issue where rapid clicks could trigger multiple concurrent save operations.
Fixed potential inconsistency between file content and knowledge updates.

Security

Prevents accidental multiple requests that could cause inconsistent server state.

Breaking Changes

None

Additional Information

Related to potential concurrency issues when updating file content.
Improves stability and user experience by ensuring only one save request is active at a time.

Screenshots or Videos

N/A

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17137 **Author:** [@acwoo97](https://github.com/acwoo97) **Created:** 9/2/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feat/knowledge-update-race-condition` --- ### 📝 Commits (1) - [`513cab9`](https://github.com/open-webui/open-webui/commit/513cab94b107679e3ca4af4f1d2160496758cd9d) fix: prevent double-save race by awaiting API calls and adding isSaving guard ### 📊 Changes **1 file changed** (+35 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Knowledge/KnowledgeBase.svelte` (+35 -25) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Ensure file content update process is serialized by adding `await` and preventing race conditions. - Added `isSaving` guard to avoid multiple save requests triggered by rapid user actions. - Improved user experience by disabling the save button during in-flight save operations. ### Added - `isSaving` state management for preventing duplicate save requests. ### Changed - File update handler now uses `await` for `updateFileDataContentById` and `updateFileFromKnowledgeById` to enforce sequential execution. - Save button behavior adjusted to be disabled when a save operation is in progress. ### Deprecated - N/A ### Removed - N/A ### Fixed - Fixed race condition issue where rapid clicks could trigger multiple concurrent save operations. - Fixed potential inconsistency between file content and knowledge updates. ### Security - Prevents accidental multiple requests that could cause inconsistent server state. ### Breaking Changes - None --- ### Additional Information - Related to potential concurrency issues when updating file content. - Improves stability and user experience by ensuring only one save request is active at a time. ### Screenshots or Videos - N/A ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:22:58 -06:00

GiteaMirror closed this issue

2025-11-11 19:22:59 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#11132