Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Redis Sentinel fail-over made our background tasks run slightly longer; if the server received SIGTERM during that window, the event loop was closed while create_task’s done_callback still tried to schedule cleanup_task. The result was noisy tracebacks:
This PR hardens the scheduling helper so the callback simply skips work
when the loop is absent or closed—no more shutdown errors.
create_task’s callback uses the helper instead of raw asyncio.create_task.
Deprecated
None
Removed
None
Fixed
RuntimeError (“no running event loop”) emitted during graceful shutdown.
Security
N/A
Breaking Changes
None
Additional Information
Verified new tests fail on previous commit and pass after the fix.
No API surface or dependency changes.
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/16014
**Author:** [@sihyeonn](https://github.com/sihyeonn)
**Created:** 7/25/2025
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `fix/sh-handling-race-runtimeerror`
---
### 📝 Commits (1)
- [`5d9f1fb`](https://github.com/open-webui/open-webui/commit/5d9f1fb7b4edd2dbc15f6053fcb92358047ac3a9) fix: prevent shutdown race RuntimeError by hardening _safe_create_task
### 📊 Changes
**2 files changed** (+80 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/tasks.py` (+12 -2)
➕ `backend/open_webui/test/util/test_task_cleanup.py` (+68 -0)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
https://github.com/open-webui/open-webui/issues/15979
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests to validate the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
Redis Sentinel fail-over made our background tasks run slightly longer; if the server received SIGTERM during that window, the event loop was closed while `create_task`’s `done_callback` still tried to schedule `cleanup_task`. The result was noisy tracebacks:
This PR hardens the scheduling helper so the callback simply skips work
when the loop is absent or closed—no more shutdown errors.
### Added
- Regression tests (`test_task_cleanup.py`) covering:
* normal loop → coroutine scheduled
* closed loop → scheduling silently skipped (was RuntimeError)
### Changed
- `_safe_create_task` now:
```python
try:
loop = asyncio.get_running_loop()
except RuntimeError:
return
if not loop.is_closed():
loop.create_task(coro)
```
- `create_task`’s callback uses the helper instead of raw
`asyncio.create_task`.
### Deprecated
- None
### Removed
- None
### Fixed
- RuntimeError (“no running event loop”) emitted during graceful shutdown.
### Security
- N/A
### Breaking Changes
- **None**
---
### Additional Information
- Verified new tests fail on previous commit and pass after the fix.
- No API surface or dependency changes.
### Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/16014
Author: @sihyeonn
Created: 7/25/2025
Status: ❌ Closed
Base:
dev← Head:fix/sh-handling-race-runtimeerror📝 Commits (1)
5d9f1fbfix: prevent shutdown race RuntimeError by hardening _safe_create_task📊 Changes
2 files changed (+80 additions, -2 deletions)
View changed files
📝
backend/open_webui/tasks.py(+12 -2)➕
backend/open_webui/test/util/test_task_cleanup.py(+68 -0)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
https://github.com/open-webui/open-webui/issues/15979
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Redis Sentinel fail-over made our background tasks run slightly longer; if the server received SIGTERM during that window, the event loop was closed while
create_task’sdone_callbackstill tried to schedulecleanup_task. The result was noisy tracebacks:This PR hardens the scheduling helper so the callback simply skips work
when the loop is absent or closed—no more shutdown errors.
Added
test_task_cleanup.py) covering:Changed
_safe_create_tasknow:create_task’s callback uses the helper instead of rawasyncio.create_task.Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.