f59da36 feat: Re-use Redis connection pools via local cache to prevent transient exhaustion
📊 Changes
1 file changed (+18 additions, -8 deletions)
View changed files
📝backend/open_webui/utils/redis.py (+18 -8)
📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Fixes connection-pool explosion and egress-policy IP depletion by re-using Redis connection pools.
Introduces a module-level cache (_CONNECTION_CACHE) to keep the number of active connections flat and improve performance.
Added
_CONNECTION_CACHE
Memoises pools by (redis_url, sentinel_hosts, async_mode, decode_responses).
Supports both sync/async and Stand-alone/Sentinel configurations.
Changed
get_redis_connection()
Looks up the cache first and re-uses an existing pool when available.
Consolidated pool-creation logic to prevent duplicate pools.
Sentinel code paths now share the same cache key and pool.
Deprecated
None
Removed
None
Fixed
Bug where connection pools were temporarily exhausted due to skewed release timing.
Eliminates Redis max-clients breaches and cluster IP-shortage alerts.
Security
While not a direct security patch, reducing excessive outbound connections lowers the risk of unintentional DoS against Redis or network infrastructure.
Breaking Changes
None
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/15980
**Author:** [@sihyeonn](https://github.com/sihyeonn)
**Created:** 7/24/2025
**Status:** ✅ Merged
**Merged:** 7/24/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `feat/sh-share-connectionpool`
---
### 📝 Commits (1)
- [`f59da36`](https://github.com/open-webui/open-webui/commit/f59da361f12ddf5fedf5511e8383749d9232e9b2) feat: Re-use Redis connection pools via local cache to prevent transient exhaustion
### 📊 Changes
**1 file changed** (+18 additions, -8 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/utils/redis.py` (+18 -8)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests to validate the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Fixes connection-pool explosion and egress-policy IP depletion by re-using Redis connection pools.
- Introduces a module-level cache (_CONNECTION_CACHE) to keep the number of active connections flat and improve performance.
### Added
- _CONNECTION_CACHE
- Memoises pools by (redis_url, sentinel_hosts, async_mode, decode_responses).
- Supports both sync/async and Stand-alone/Sentinel configurations.
### Changed
- get_redis_connection()
- Looks up the cache first and re-uses an existing pool when available.
- Consolidated pool-creation logic to prevent duplicate pools.
- Sentinel code paths now share the same cache key and pool.
### Deprecated
- None
### Removed
- None
### Fixed
- Bug where connection pools were temporarily exhausted due to skewed release timing.
- Eliminates Redis max-clients breaches and cluster IP-shortage alerts.
### Security
- While not a direct security patch, reducing excessive outbound connections lowers the risk of unintentional DoS against Redis or network infrastructure.
### Breaking Changes
- None
---
### Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/15980
Author: @sihyeonn
Created: 7/24/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @tjbck
Base:
dev← Head:feat/sh-share-connectionpool📝 Commits (1)
f59da36feat: Re-use Redis connection pools via local cache to prevent transient exhaustion📊 Changes
1 file changed (+18 additions, -8 deletions)
View changed files
📝
backend/open_webui/utils/redis.py(+18 -8)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.