[PR #16846] [CLOSED] fix: only save the chat while it`s streamed if ENABLE_REALTIME_CHAT_SAVE #11053

New Issue

GiteaMirror · 2025-11-11T19:20:45-06:00

GiteaMirror commented

2025-11-11 19:20:45 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16846
Author: @aleprj
Created: 8/22/2025
Status: ❌ Closed

Base: dev ← Head: respect_save_variable

📝 Commits (2)

cf537d0 fix: only save the chat while it`s streamed if ENABLE_REALTIME_CHAT_SAVE is set to TRUE
975b933 fix: adjust formatting (as suggested by the formatting tool)

📊 Changes

3 files changed (+17 additions, -7 deletions)

View changed files

📝 backend/open_webui/functions.py (+4 -2)
📝 backend/open_webui/utils/chat.py (+11 -3)
📝 backend/open_webui/utils/middleware.py (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Chat would be saved after each chunk received while streaming, and it would slow down the system a lot while dealing with large files. We now respect the ENABLE_REALTIME_CHAT_SAVE variable and only saved during the stream if it's set to true.

Added

Changed

Deprecated

Removed

Fixed

Chat will only be saved while streaming if ENABLE_REALTIME_CHAT_SAVE is set. It avoids slowing down with large files or contexts.

Security

Breaking Changes

Additional Information

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16846 **Author:** [@aleprj](https://github.com/aleprj) **Created:** 8/22/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `respect_save_variable` --- ### 📝 Commits (2) - [`cf537d0`](https://github.com/open-webui/open-webui/commit/cf537d00c2ad8aee39d9f81b5d5c8b6c917ddbd3) fix: only save the chat while it`s streamed if ENABLE_REALTIME_CHAT_SAVE is set to TRUE - [`975b933`](https://github.com/open-webui/open-webui/commit/975b9339d520ddc4fe332a26361c4fb7870a2e58) fix: adjust formatting (as suggested by the formatting tool) ### 📊 Changes **3 files changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/functions.py` (+4 -2) 📝 `backend/open_webui/utils/chat.py` (+11 -3) 📝 `backend/open_webui/utils/middleware.py` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Chat would be saved after each chunk received while streaming, and it would slow down the system a lot while dealing with large files. We now respect the ENABLE_REALTIME_CHAT_SAVE variable and only saved during the stream if it's set to true. ### Added ### Changed ### Deprecated ### Removed ### Fixed - Chat will only be saved while streaming if ENABLE_REALTIME_CHAT_SAVE is set. It avoids slowing down with large files or contexts. ### Security ### Breaking Changes --- ### Additional Information ### Screenshots or Videos ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:20:45 -06:00

GiteaMirror closed this issue

2025-11-11 19:20:46 -06:00

GiteaMirror referenced this issue

2026-04-19 22:13:38 -05:00

[GH-ISSUE #11439] issue: `Incorrect API key provided` (in logs) or `SyntaxError: Unexpected token ':', ": OPENROUT"... is not valid JSON` in UI with non-openai endpoint #16230

GiteaMirror referenced this issue

2026-04-25 05:40:00 -05:00

[GH-ISSUE #11439] issue: `Incorrect API key provided` (in logs) or `SyntaxError: Unexpected token ':', ": OPENROUT"... is not valid JSON` in UI with non-openai endpoint #31759

GiteaMirror referenced this issue

2026-05-05 16:51:24 -05:00

[GH-ISSUE #11439] issue: `Incorrect API key provided` (in logs) or `SyntaxError: Unexpected token ':', ": OPENROUT"... is not valid JSON` in UI with non-openai endpoint #54896