Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Currently, when a file is removed from a knowledge base it is also deleted from the database, but not the backing store. For security and capacity reasons, files should not be left in storage after being fully deleted from open-webui.
Fixed
Add deletion of stored file when file is removed from knowledge base and Files database table
Additional Information
The way the current code works, we can't delegate this to the DELETE files/{id} route, so I duplicated the logic from there in the remove route under knowledge.
Screenshots or Videos
[Attach any relevant screenshots or videos demonstrating the changes]
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/12195
**Author:** [@kaytwo](https://github.com/kaytwo)
**Created:** 3/30/2025
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `delete-knowledge-properly`
---
### 📝 Commits (1)
- [`aa12dc1`](https://github.com/open-webui/open-webui/commit/aa12dc13cb253e9a94819b2bc3e517d6eb26c8bb) also delete the stored file
### 📊 Changes
**1 file changed** (+12 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/routers/knowledge.py` (+12 -2)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
Currently, when a file is removed from a knowledge base it is also deleted from the database, but not the backing store. For security and capacity reasons, files should not be left in storage after being fully deleted from open-webui.
### Fixed
- Add deletion of stored file when file is removed from knowledge base and Files database table
---
### Additional Information
The way the current code works, we can't delegate this to the `DELETE files/{id}` route, so I duplicated the logic from there in the `remove` route under knowledge.
### Screenshots or Videos
- [Attach any relevant screenshots or videos demonstrating the changes]
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/12195
Author: @kaytwo
Created: 3/30/2025
Status: ❌ Closed
Base:
dev← Head:delete-knowledge-properly📝 Commits (1)
aa12dc1also delete the stored file📊 Changes
1 file changed (+12 additions, -2 deletions)
View changed files
📝
backend/open_webui/routers/knowledge.py(+12 -2)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Currently, when a file is removed from a knowledge base it is also deleted from the database, but not the backing store. For security and capacity reasons, files should not be left in storage after being fully deleted from open-webui.
Fixed
Additional Information
The way the current code works, we can't delegate this to the
DELETE files/{id}route, so I duplicated the logic from there in theremoveroute under knowledge.Screenshots or Videos
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.