github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-15 12:36:27 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #7425] [CLOSED] Fix: User Chats modal - improved handling of data fetching. Avoid showing previous users chats while fetching. #109367

New Issue
Closed
opened 2026-05-18 08:43:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-18 08:43:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/7425
Author: @DmitriyAlergant
Created: 11/27/2024
Status: ❌ Closed

Base: dev ← Head: fix/user_chats_modal_clear

📝 Commits (2)

  • 6649cd7 User Chats Modal improved handling of data fetching. Avoid showing previous user chats while still fetching + requires new i18n term for 'Loading...'
  • 798dd63 Executable bit +x for run.sh

📊 Changes

51 files changed (+67 additions, -8 deletions)

View changed files

📝 run.sh (+0 -0)
📝 src/app.css (+0 -1)
📝 src/lib/components/admin/Users/UserList/UserChatsModal.svelte (+18 -4)
📝 src/lib/components/chat/Messages.svelte (+1 -1)
📝 src/lib/components/layout/Sidebar.svelte (+2 -2)
📝 src/lib/i18n/locales/ar-BH/translation.json (+1 -0)
📝 src/lib/i18n/locales/bg-BG/translation.json (+1 -0)
📝 src/lib/i18n/locales/bn-BD/translation.json (+1 -0)
📝 src/lib/i18n/locales/ca-ES/translation.json (+1 -0)
📝 src/lib/i18n/locales/ceb-PH/translation.json (+1 -0)
📝 src/lib/i18n/locales/cs-CZ/translation.json (+1 -0)
📝 src/lib/i18n/locales/da-DK/translation.json (+1 -0)
📝 src/lib/i18n/locales/de-DE/translation.json (+1 -0)
📝 src/lib/i18n/locales/dg-DG/translation.json (+1 -0)
📝 src/lib/i18n/locales/en-GB/translation.json (+1 -0)
📝 src/lib/i18n/locales/en-US/translation.json (+1 -0)
📝 src/lib/i18n/locales/es-ES/translation.json (+1 -0)
📝 src/lib/i18n/locales/fa-IR/translation.json (+1 -0)
📝 src/lib/i18n/locales/fi-FI/translation.json (+1 -0)
📝 src/lib/i18n/locales/fr-CA/translation.json (+1 -0)

...and 31 more files

📄 Description

Pull Request Checklist

Improved handling of data fetching in User Chats modal (admin looking at user chats). This avoids showing previous users chats while still fetching (which sometimes can be delayed), which can be confusing and misleading.

  • another commit added +x executable bit to ./run.sh script, it is supposed to be runnable.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Improved handling of data fetching in User Chats modal (admins button to look at userы chats). This avoids showing previous users chats while still fetching data (which sometimes can be delayed). Which can be confusing and misleading.

Fixed

  • User Chats modal was momentarily showing previous users chats (or the "user has no chats" message) while still fetching chats for the new user, which was confusing and misleading to an admin in cases data fetch was delayed or failed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/7425 **Author:** [@DmitriyAlergant](https://github.com/DmitriyAlergant) **Created:** 11/27/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/user_chats_modal_clear` --- ### 📝 Commits (2) - [`6649cd7`](https://github.com/open-webui/open-webui/commit/6649cd749d7d833c869d398d782e1c333fc4a366) User Chats Modal improved handling of data fetching. Avoid showing previous user chats while still fetching + requires new i18n term for 'Loading...' - [`798dd63`](https://github.com/open-webui/open-webui/commit/798dd63afb398a9884bc596010a3df131cf926cd) Executable bit +x for run.sh ### 📊 Changes **51 files changed** (+67 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `run.sh` (+0 -0) 📝 `src/app.css` (+0 -1) 📝 `src/lib/components/admin/Users/UserList/UserChatsModal.svelte` (+18 -4) 📝 `src/lib/components/chat/Messages.svelte` (+1 -1) 📝 `src/lib/components/layout/Sidebar.svelte` (+2 -2) 📝 `src/lib/i18n/locales/ar-BH/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/bg-BG/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/bn-BD/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/ca-ES/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/ceb-PH/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/cs-CZ/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/da-DK/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/dg-DG/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/en-GB/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/en-US/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/es-ES/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/fa-IR/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/fi-FI/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/fr-CA/translation.json` (+1 -0) _...and 31 more files_ </details> ### 📄 Description # Pull Request Checklist Improved handling of data fetching in User Chats modal (admin looking at user chats). This avoids showing previous users chats while still fetching (which sometimes can be delayed), which can be confusing and misleading. + another commit added +x executable bit to ./run.sh script, it is supposed to be runnable. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests for validating the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Improved handling of data fetching in User Chats modal (admins button to look at userы chats). This avoids showing previous users chats while still fetching data (which sometimes can be delayed). Which can be confusing and misleading. ### Fixed - User Chats modal was momentarily showing previous users chats (or the "user has no chats" message) while still fetching chats for the new user, which was confusing and misleading to an admin in cases data fetch was delayed or failed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-18 08:43:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#109367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?