Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Fix type errors.
Added
Property profile_image_url in interface ModelMeta
Property owned_by in interface BaseModel, OpenAIModel, and OllamaModel
Property ollama in interface OllamaModel
Changed
Declare urlIdx and selectedOllamaUrlIdx as number: they are actually numbers instead of strings.
Declare variable languages and keepAlive with appropriate type.
Declare attribute items of ModelSelector/Selector as array, add property model.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/4746
**Author:** [@5E-324](https://github.com/5E-324)
**Created:** 8/20/2024
**Status:** ✅ Merged
**Merged:** 8/20/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix-type-errors`
---
### 📝 Commits (1)
- [`fd26e56`](https://github.com/open-webui/open-webui/commit/fd26e5635d2d318ed7ac4589ab902e9ff3f0bd2a) Fix type errors.
### 📊 Changes
**7 files changed** (+28 additions, -7 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/apis/index.ts` (+1 -0)
📝 `src/lib/apis/ollama/index.ts` (+1 -1)
📝 `src/lib/components/admin/Settings/Models.svelte` (+1 -1)
📝 `src/lib/components/chat/ModelSelector/Selector.svelte` (+3 -2)
📝 `src/lib/components/chat/Settings/General.svelte` (+2 -2)
📝 `src/lib/components/chat/Settings/Models.svelte` (+1 -1)
📝 `src/lib/stores/index.ts` (+19 -0)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
Fix type errors.
### Added
- Property profile_image_url in interface ModelMeta
- Property owned_by in interface BaseModel, OpenAIModel, and OllamaModel
- Property ollama in interface OllamaModel
### Changed
- Declare urlIdx and selectedOllamaUrlIdx as number: they are actually numbers instead of strings.
- Declare variable languages and keepAlive with appropriate type.
- Declare attribute items of ModelSelector/Selector as array, add property model.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/4746
Author: @5E-324
Created: 8/20/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @tjbck
Base:
dev← Head:fix-type-errors📝 Commits (1)
fd26e56Fix type errors.📊 Changes
7 files changed (+28 additions, -7 deletions)
View changed files
📝
src/lib/apis/index.ts(+1 -0)📝
src/lib/apis/ollama/index.ts(+1 -1)📝
src/lib/components/admin/Settings/Models.svelte(+1 -1)📝
src/lib/components/chat/ModelSelector/Selector.svelte(+3 -2)📝
src/lib/components/chat/Settings/General.svelte(+2 -2)📝
src/lib/components/chat/Settings/Models.svelte(+1 -1)📝
src/lib/stores/index.ts(+19 -0)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Fix type errors.
Added
Changed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.