log reconnection attempts
mark session_id as mandatory on client-side
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
[X ] Target branch: Please verify that the pull request targets the dev branch.
[C ] Description: Provide a concise description of the changes made in this pull request.
[C ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Make reconnection explicit and verbose to help fixing #4158
Changed
make websocket reconnection explicit
make session_id mandatory on client-side
provide log for reconnection attempts to investigate random disconnections
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/4431
**Author:** [@nowheresly](https://github.com/nowheresly)
**Created:** 8/7/2024
**Status:** ✅ Merged
**Merged:** 8/7/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix4158_reconnect`
---
### 📝 Commits (1)
- [`2fb4d33`](https://github.com/open-webui/open-webui/commit/2fb4d3356cbf3173b5d9b6d50f080538063d7967) fix: #4158 allow reconnection when websocket is closed
### 📊 Changes
**2 files changed** (+20 additions, -0 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/apis/index.ts` (+1 -0)
📝 `src/routes/+layout.svelte` (+19 -0)
</details>
### 📄 Description
log reconnection attempts
mark session_id as mandatory on client-side
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [X ] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [C ] **Description:** Provide a concise description of the changes made in this pull request.
- [C ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [ ] **Testing:** Have you written and run sufficient tests for validating the changes?
- [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Make reconnection explicit and verbose to help fixing #4158
### Changed
- make websocket reconnection explicit
- make session_id mandatory on client-side
- provide log for reconnection attempts to investigate random disconnections
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/4431
Author: @nowheresly
Created: 8/7/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @tjbck
Base:
dev← Head:fix4158_reconnect📝 Commits (1)
2fb4d33fix: #4158 allow reconnection when websocket is closed📊 Changes
2 files changed (+20 additions, -0 deletions)
View changed files
📝
src/lib/apis/index.ts(+1 -0)📝
src/routes/+layout.svelte(+19 -0)📄 Description
log reconnection attempts
mark session_id as mandatory on client-side
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Changed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.