Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the
Changelog Entry
Description
Add ability to select model in model selection dialog using the enter key.
Feature detailed in #3960.
Added
Event key listener on:keydown on src/lib/components/ModelSelector/Selector.svelteinput tag to check for the keydown event including the enter key to trigger a model selection.
Additional Information
Manually tested edge cases:
0 search results does not cause an error
selection via enter keydown is only triggered if the input is in focus
other ideas
indicator to show the user enter selects the top result
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/3962
**Author:** [@thearyadev](https://github.com/thearyadev)
**Created:** 7/17/2024
**Status:** ✅ Merged
**Merged:** 7/18/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `feat/enter-to-select-model`
---
### 📝 Commits (1)
- [`133f223`](https://github.com/open-webui/open-webui/commit/133f223df6541716d4f1b86c1dd1c3a48b6829c5) feat: enter selects first model in list
### 📊 Changes
**1 file changed** (+7 additions, -0 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/components/chat/ModelSelector/Selector.svelte` (+7 -0)
</details>
### 📄 Description
# Pull Request Checklist
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the
# Changelog Entry
### Description
Add ability to select model in model selection dialog using the enter key.
Feature detailed in #3960.
### Added
- Event key listener `on:keydown` on `src/lib/components/ModelSelector/Selector.svelte` `input` tag to check for the keydown event including the `enter` key to trigger a model selection.
### Additional Information
- Manually tested edge cases:
- 0 search results does not cause an error
- selection via `enter` keydown is only triggered if the input is in focus
- other ideas
- indicator to show the user `enter` selects the top result
### Screenshots or Videos
https://github.com/user-attachments/assets/e53e2861-93db-4143-a84b-0bf6e872df71
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/3962
Author: @thearyadev
Created: 7/17/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @tjbck
Base:
dev← Head:feat/enter-to-select-model📝 Commits (1)
133f223feat: enter selects first model in list📊 Changes
1 file changed (+7 additions, -0 deletions)
View changed files
📝
src/lib/components/chat/ModelSelector/Selector.svelte(+7 -0)📄 Description
Pull Request Checklist
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Add ability to select model in model selection dialog using the enter key.
Feature detailed in #3960.
Added
on:keydownonsrc/lib/components/ModelSelector/Selector.svelteinputtag to check for the keydown event including theenterkey to trigger a model selection.Additional Information
enterkeydown is only triggered if the input is in focusenterselects the top resultScreenshots or Videos
https://github.com/user-attachments/assets/e53e2861-93db-4143-a84b-0bf6e872df71
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.