[PR #2943] [MERGED] fix: model settings temperature not passed correctly from model settings to ollama/openai api #108448

New Issue

2026-05-18T07:28:32-05:00

GiteaMirror commented

2026-05-18 07:28:32 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2943
Author: @choltha
Created: 6/9/2024
Status: ✅ Merged
Merged: 6/9/2024
Merged by: @tjbck

Base: dev ← Head: fix/temperature-params

📝 Commits (1)

97b3911 fix: temperature not passed correctly

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 backend/apps/ollama/main.py (+1 -1)
📝 backend/apps/openai/main.py (+2 -2)

📄 Description

Pull Request Checklist

Description

Simple fix for passing the temperature:

if temperature is "0" it doesn't get added to the API call params
openai param is int-casted, so right now the value is always 1 or 0

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
~~[ ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?~~
- not relevant, bugfix
~~[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?~~
- no, just a fix
Testing: Have you written and run sufficient tests for validating the changes?
- did manual tests to confirm its now working as intended
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Fixed

fix: model settings temperature not passed correctly from model settings to ollama/openai api

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2943 **Author:** [@choltha](https://github.com/choltha) **Created:** 6/9/2024 **Status:** ✅ Merged **Merged:** 6/9/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/temperature-params` --- ### 📝 Commits (1) - [`97b3911`](https://github.com/open-webui/open-webui/commit/97b39115a13e14e2b2a6532fa5204f0ecf221d49) fix: temperature not passed correctly ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/ollama/main.py` (+1 -1) 📝 `backend/apps/openai/main.py` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ## Description Simple fix for passing the temperature: 1. if temperature is "0" it doesn't get added to the API call params 2. openai param is int-casted, so right now the value is always 1 or 0 ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - ~[ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?~ - not relevant, bugfix - ~[ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?~ - no, just a fix - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - did manual tests to confirm its now working as intended - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Fixed - fix: model settings temperature not passed correctly from model settings to ollama/openai api --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-18 07:28:32 -05:00

GiteaMirror closed this issue

2026-05-18 07:28:34 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#108448