[PR #16117] [MERGED] fix: "Autocomplete Generation" toggle would appear enabled breifly, even when disabled #10833

New Issue

GiteaMirror · 2025-11-11T19:15:01-06:00

GiteaMirror commented

2025-11-11 19:15:01 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16117
Author: @silentoplayz
Created: 7/29/2025
Status: ✅ Merged
Merged: 7/29/2025
Merged by: @tjbck

Base: dev ← Head: fix-autocomplete-toggle

📝 Commits (1)

a63b447 fix-autocomplete-toggle

📊 Changes

1 file changed (+8 additions, -8 deletions)

View changed files

📝 src/lib/components/admin/Settings/Interface.svelte (+8 -8)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request addresses two bugs on the Admin Settings Interface page. The first bug caused the "Autocomplete Generation" toggle to appear enabled briefly, even when disabled. The second bug, introduced while fixing the first, caused a console error (updateBanners is not defined).

Changed

Modified src/lib/components/admin/Settings/Interface.svelte to ensure that the component's state is fully loaded before it is rendered, preventing the "Autocomplete Generation" toggle from briefly showing an incorrect state.

Fixed

Fixed a bug where the "Autocomplete Generation" toggle would briefly appear enabled on page load, even when the setting was disabled.
Fixed a bug that caused a ReferenceError: updateBanners is not defined in the browser console.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16117 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 7/29/2025 **Status:** ✅ Merged **Merged:** 7/29/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-autocomplete-toggle` --- ### 📝 Commits (1) - [`a63b447`](https://github.com/open-webui/open-webui/commit/a63b447992c4d1d3b3653c98986839fd7cffdc21) fix-autocomplete-toggle ### 📊 Changes **1 file changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings/Interface.svelte` (+8 -8) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request addresses two bugs on the Admin Settings Interface page. The first bug caused the "Autocomplete Generation" toggle to appear enabled briefly, even when disabled. The second bug, introduced while fixing the first, caused a console error (`updateBanners is not defined`). ### Changed - Modified `src/lib/components/admin/Settings/Interface.svelte` to ensure that the component's state is fully loaded before it is rendered, preventing the "Autocomplete Generation" toggle from briefly showing an incorrect state. ### Fixed - Fixed a bug where the "Autocomplete Generation" toggle would briefly appear enabled on page load, even when the setting was disabled. - Fixed a bug that caused a `ReferenceError: updateBanners is not defined` in the browser console. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:15:01 -06:00

GiteaMirror closed this issue

2025-11-11 19:15:02 -06:00

GiteaMirror referenced this issue

2026-04-19 22:05:19 -05:00

[GH-ISSUE #10833] Connection failed for Ollama with default docker command for Ollama #16047

GiteaMirror referenced this issue

2026-04-25 05:28:27 -05:00

[GH-ISSUE #10833] Connection failed for Ollama with default docker command for Ollama #31576

GiteaMirror referenced this issue

2026-05-05 16:35:36 -05:00

[GH-ISSUE #10833] Connection failed for Ollama with default docker command for Ollama #54713