[PR #16098] [CLOSED] feat: Add confirm password field to sign up #10828

New Issue

GiteaMirror · 2025-11-11T19:14:55-06:00

GiteaMirror commented

2025-11-11 19:14:55 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16098
Author: @silentoplayz
Created: 7/28/2025
Status: ❌ Closed

Base: dev ← Head: feat/confirm-password-on-signup-page

📝 Commits (1)

3d6b8aa feat: Add confirm password field to sign up

📊 Changes

5 files changed (+43 additions, -6 deletions)

View changed files

📝 backend/open_webui/constants.py (+1 -0)
📝 backend/open_webui/models/auths.py (+1 -0)
📝 backend/open_webui/routers/auths.py (+3 -0)
📝 src/lib/apis/auths/index.ts (+2 -0)
📝 src/routes/auth/+page.svelte (+36 -6)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request introduces a "Confirm Password" field to the user sign-up page. This enhancement improves user experience by verifying that the user has entered their desired password correctly, reducing the chance of password-related errors upon account creation.

Added

Confirm Password Field: A new input field has been added to the sign-up form for password confirmation.
Password Match Validation: Both frontend and backend validation have been implemented to ensure that the entered passwords match.
Error Messaging: A user-friendly error message is now displayed if the passwords do not match.

Changed

Sign-Up Form: The sign-up form in src/routes/auth/+page.svelte has been updated to include the new "Confirm Password" field.
Backend API: The /auths/signup endpoint and its corresponding SignupForm model have been updated to handle the confirm_password field.
API Function: The userSignUp function in src/lib/apis/auths/index.ts has been modified to send the confirm_password to the backend.

Security

Spammers may need to re-write their automatic sign-up attack scripts to confirm their password upon sign-up now? Idk. Sounds like a win to me though!

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16098 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 7/28/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/confirm-password-on-signup-page` --- ### 📝 Commits (1) - [`3d6b8aa`](https://github.com/open-webui/open-webui/commit/3d6b8aad272cb9d4ff93b5847eb50ef66aabd0ea) feat: Add confirm password field to sign up ### 📊 Changes **5 files changed** (+43 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/constants.py` (+1 -0) 📝 `backend/open_webui/models/auths.py` (+1 -0) 📝 `backend/open_webui/routers/auths.py` (+3 -0) 📝 `src/lib/apis/auths/index.ts` (+2 -0) 📝 `src/routes/auth/+page.svelte` (+36 -6) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request introduces a "Confirm Password" field to the user sign-up page. This enhancement improves user experience by verifying that the user has entered their desired password correctly, reducing the chance of password-related errors upon account creation. ### Added - **Confirm Password Field**: A new input field has been added to the sign-up form for password confirmation. - **Password Match Validation**: Both frontend and backend validation have been implemented to ensure that the entered passwords match. - **Error Messaging**: A user-friendly error message is now displayed if the passwords do not match. ### Changed - **Sign-Up Form**: The sign-up form in `src/routes/auth/+page.svelte` has been updated to include the new "Confirm Password" field. - **Backend API**: The `/auths/signup` endpoint and its corresponding `SignupForm` model have been updated to handle the `confirm_password` field. - **API Function**: The `userSignUp` function in `src/lib/apis/auths/index.ts` has been modified to send the `confirm_password` to the backend. ### Security - Spammers may need to re-write their automatic sign-up attack scripts to confirm their password upon sign-up now? Idk. Sounds like a win to me though! ### Screenshots or Videos <img width="705" height="559" alt="image" src="https://github.com/user-attachments/assets/60608fe7-afda-4838-9d79-6dfa723b6d8b" /> <img width="1577" height="893" alt="image" src="https://github.com/user-attachments/assets/cdf09861-1adb-405e-95cb-37cbcbc250d5" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:14:55 -06:00

GiteaMirror closed this issue

2025-11-11 19:14:55 -06:00

GiteaMirror referenced this issue

2026-04-19 22:05:14 -05:00

[GH-ISSUE #10828] API接入失败 #16044

GiteaMirror referenced this issue

2026-04-25 05:28:21 -05:00

[GH-ISSUE #10828] API接入失败 #31573

GiteaMirror referenced this issue

2026-05-05 16:35:20 -05:00

[GH-ISSUE #10828] API接入失败 #54710