61bb1f1 fix: do not use hardware ID in document ID generation
📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝backend/apps/rag/main.py (+1 -1)
📄 Description
Description
uuid.uuid1() uses the machine's hardware ID (among other things) for UUID generation. I see no reason to use partially deterministic IDs here; every other use of UUIDs in the project seems to be using the random uuid4() function.
Changelog Entry
Fixed
Vector database document IDs no longer use deterministic UUIDv1 identifiers.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/2040
**Author:** [@akx](https://github.com/akx)
**Created:** 5/7/2024
**Status:** ✅ Merged
**Merged:** 5/7/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `uuid4`
---
### 📝 Commits (1)
- [`61bb1f1`](https://github.com/open-webui/open-webui/commit/61bb1f1dc84e078e397e61456af30c2e363e821a) fix: do not use hardware ID in document ID generation
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/apps/rag/main.py` (+1 -1)
</details>
### 📄 Description
## Description
[`uuid.uuid1()`](https://docs.python.org/3.12/library/uuid.html#index-5) uses the machine's hardware ID (among other things) for UUID generation. I see no reason to use partially deterministic IDs here; every other use of UUIDs in the project seems to be using the random `uuid4()` function.
---
### Changelog Entry
### Fixed
- Vector database document IDs no longer use deterministic UUIDv1 identifiers.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/2040
Author: @akx
Created: 5/7/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @tjbck
Base:
dev← Head:uuid4📝 Commits (1)
61bb1f1fix: do not use hardware ID in document ID generation📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
backend/apps/rag/main.py(+1 -1)📄 Description
Description
uuid.uuid1()uses the machine's hardware ID (among other things) for UUID generation. I see no reason to use partially deterministic IDs here; every other use of UUIDs in the project seems to be using the randomuuid4()function.Changelog Entry
Fixed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.