Description: Briefly describe the changes in this pull request.
Description
Workflows are not currently failing when the formatters produce a diff. This PR modifies the workflows to run a git diff after the formatters run to catch any unformatted code that was formatted.
As this hasn't been enforced in a while, this produces a massive diff that would need to be applied to actually merge the change in, and would likely result in merge conflicts for any in-flight PRs.
The frontend build is set to always run even if the format step fails, as it's useful to know if it's just a formatting issue, or if the PR doesn't build at all.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/1348
**Author:** [@cheahjs](https://github.com/cheahjs)
**Created:** 3/28/2024
**Status:** ✅ Merged
**Merged:** 3/29/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix/format-actions-enforce`
---
### 📝 Commits (1)
- [`f34fe49`](https://github.com/open-webui/open-webui/commit/f34fe49bdde4b44fe1d5c78857791acca4e2ad4b) fix: enforce formatters on GitHub Actions
### 📊 Changes
**2 files changed** (+5 additions, -0 deletions)
<details>
<summary>View changed files</summary>
📝 `.github/workflows/format-backend.yaml` (+2 -0)
📝 `.github/workflows/format-build-frontend.yaml` (+3 -0)
</details>
### 📄 Description
## Pull Request Checklist
- [x] **Description:** Briefly describe the changes in this pull request.
---
## Description
Workflows are not currently failing when the formatters produce a diff. This PR modifies the workflows to run a `git diff` after the formatters run to catch any unformatted code that was formatted.
As this hasn't been enforced in a while, this produces a massive diff that would need to be applied to actually merge the change in, and would likely result in merge conflicts for any in-flight PRs.
The frontend build is set to always run even if the format step fails, as it's useful to know if it's just a formatting issue, or if the PR doesn't build at all.
Example runs:
* Python: https://github.com/cheahjs/open-webui-fork/actions/runs/8475065194/job/23222525498
* JS: https://github.com/cheahjs/open-webui-fork/actions/runs/8475065195/job/23222525488
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/1348
Author: @cheahjs
Created: 3/28/2024
Status: ✅ Merged
Merged: 3/29/2024
Merged by: @tjbck
Base:
dev← Head:fix/format-actions-enforce📝 Commits (1)
f34fe49fix: enforce formatters on GitHub Actions📊 Changes
2 files changed (+5 additions, -0 deletions)
View changed files
📝
.github/workflows/format-backend.yaml(+2 -0)📝
.github/workflows/format-build-frontend.yaml(+3 -0)📄 Description
Pull Request Checklist
Description
Workflows are not currently failing when the formatters produce a diff. This PR modifies the workflows to run a
git diffafter the formatters run to catch any unformatted code that was formatted.As this hasn't been enforced in a while, this produces a massive diff that would need to be applied to actually merge the change in, and would likely result in merge conflicts for any in-flight PRs.
The frontend build is set to always run even if the format step fails, as it's useful to know if it's just a formatting issue, or if the PR doesn't build at all.
Example runs:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.