[PR #15452] [MERGED] chore: removed requirement for providing api key in openai embedder #10634

New Issue

GiteaMirror · 2025-11-11T19:09:46-06:00

GiteaMirror commented

2025-11-11 19:09:46 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15452
Author: @expruc
Created: 7/1/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @tjbck

Base: dev ← Head: chore/remove_embedder_openai_api_key_requirement

📝 Commits (1)

555c449 removed requirement for providing api key in openai embedder

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 src/lib/components/admin/Settings/Documents.svelte (+5 -5)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Removed the requirement for providing API key when configuring an OpenAI embedder through the UI. This is for VLLM setups that don't require providing API key.

Removed

When configuring OpenAI embedder through the UI user no longer must provide API key.

Additional Information

This change is meant to make working with OpenAI embedder like other OpenAI models and connections, which don't require providing API key. Also, configuring the embedder through environment variables doesn't require providing API key, which makes user unable to save the settings on the UI (document settings) without providing a dummy API key for the embedder.

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15452 **Author:** [@expruc](https://github.com/expruc) **Created:** 7/1/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `chore/remove_embedder_openai_api_key_requirement` --- ### 📝 Commits (1) - [`555c449`](https://github.com/open-webui/open-webui/commit/555c449f49e617e58ed590cfe909453c4e31f902) removed requirement for providing api key in openai embedder ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings/Documents.svelte` (+5 -5) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Removed the requirement for providing API key when configuring an OpenAI embedder through the UI. This is for VLLM setups that don't require providing API key. ### Removed - When configuring OpenAI embedder through the UI user no longer must provide API key. --- ### Additional Information - This change is meant to make working with OpenAI embedder like other OpenAI models and connections, which don't require providing API key. Also, configuring the embedder through environment variables doesn't require providing API key, which makes user unable to save the settings on the UI (document settings) without providing a dummy API key for the embedder. ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:09:46 -06:00

GiteaMirror closed this issue

2025-11-11 19:09:46 -06:00

GiteaMirror referenced this issue

2026-04-19 20:34:07 -05:00

[GH-ISSUE #5686] bug: "Allow User Location" shouldn't be synced. #14084

GiteaMirror referenced this issue

2026-04-20 04:14:42 -05:00

[PR #10634] [MERGED] fix: Handle no location permission #22572

GiteaMirror referenced this issue

2026-04-25 03:58:34 -05:00

[GH-ISSUE #5686] bug: "Allow User Location" shouldn't be synced. #29612